Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make file references global jshint, but local recess, uglify, etc... #7043

Closed
marksulls opened this issue Feb 22, 2013 · 6 comments
Closed

Comments

@marksulls
Copy link

From the makefile (only relevant lines):

@jshint js/*.js --config js/.jshintrc
@jshint js/tests/unit/*.js --config js/.jshintrc
@./node_modules/.bin/recess --compile ${BOOTSTRAP_LESS} > ${BOOTSTRAP}
@./node_modules/.bin/recess --compile ${BOOTSTRAP_RESPONSIVE_LESS} > ${BOOTSTRAP_RESPONSIVE}
@./node_modules/.bin/uglifyjs -nc docs/assets/js/bootstrap.js > docs/assets/js/bootstrap.min.tmp.js

I think this is a bug because the make file doesn't respect the package.json, and if your global version of jshint is 1.0.0 (the latest when doing an npm install jshint), then that part of the build will fail like so:

##################################################
Building Bootstrap...
##################################################
js/bootstrap-alert.js: line 23, col 17, Bad option: ';_;'.
js/bootstrap-button.js: line 23, col 17, Bad option: ';_;'.
js/bootstrap-carousel.js: line 23, col 17, Bad option: ';_;'.
js/bootstrap-collapse.js: line 23, col 17, Bad option: ';_;'.
js/bootstrap-dropdown.js: line 23, col 17, Bad option: ';_;'.
js/bootstrap-modal.js: line 23, col 17, Bad option: ';_;'.
js/bootstrap-popover.js: line 23, col 17, Bad option: ';_;'.
js/bootstrap-scrollspy.js: line 23, col 17, Bad option: ';_;'.
js/bootstrap-tab.js: line 23, col 17, Bad option: ';_;'.
js/bootstrap-tooltip.js: line 24, col 17, Bad option: ';_;'.
js/bootstrap-transition.js: line 23, col 17, Bad option: ';_;'.
js/bootstrap-typeahead.js: line 23, col 17, Bad option: ';_;'.

12 errors
make: *** [build] Error 2

Relevant information:

> jshint -version
jshint v1.0.0
> ruby -v
ruby 1.9.3p392 (2013-02-22 revision 39386) [x86_64-darwin12.2.0]
> node -v
v0.8.20
OSX 10.8.2

If the makefile references the local one as well, then it's all good.

@marksulls
Copy link
Author

oops, missed this in my search sorry. dupes #7022

@anthonylouisburns
Copy link

How do I get a local version, I only have jshint installed globally

do I need to install a different version?

@cvrebert
Copy link
Collaborator

cvrebert commented Mar 4, 2013

@burnstony: per the README, just do npm install inside your bootstrap folder.

@adamjgrant
Copy link

I'm still getting these errors.

@dtfinch
Copy link

dtfinch commented Mar 18, 2013

Newer versions of jshint treat those crying-face "// jshint ;_;" comments as commands/options and reports errors when it can't parse them. The older version specified in bootstrap's dependencies silently ignores bad options.

jshint/jshint#395

@cvrebert
Copy link
Collaborator

@ajkochanowicz @dtfinch: file a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants