Update print styles borrowed from h5bp #20821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 2, 2016
| // content: " (" attr(href) ")"; | ||
| //} | ||
|
|
||
| abbr[title]::after { | ||
| abbr[title]:after { |
There was a problem hiding this comment.
Begin pseudo elements with double colons: ::
most notable change: - fixes print/print preview crash in IE11 (caused by `*:first-line` selector)
|
@twbs/team note there seem to be conflicting requirements in the checks...hound wants "::" for pseudo selectors, while travis wants single ":" |
Closed
twbs-savage
pushed a commit
to twbs-savage/bootstrap
that referenced
this pull request
Oct 3, 2016
With apologies, copy/paste error following on from trying to fix conflicting Hound/Travis checks for twbs#20821 slipped through before I noticed them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20814 - print/print preview crash in IE11 (caused by
*:first-lineselector)