Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect docs.min.js bundle source. #21591

Merged
merged 1 commit into from
Jan 8, 2017
Merged

Fix incorrect docs.min.js bundle source. #21591

merged 1 commit into from
Jan 8, 2017

Conversation

bardiharborow
Copy link
Member

Errata from #21414. Fixes #21570. I misunderstood how the docs.min.js bundle worked, and included jQuery and Tether in it, which are already included in the page separately. Apparently Tether does not like being loaded twice. This was only detected when we shipped because that's the only time we compile the docs with github: true. Apologies for this mess up. 😕

@bardiharborow bardiharborow merged commit cdf7320 into twbs:v4-dev Jan 8, 2017
@bardiharborow bardiharborow deleted the docs-uglify-fix branch January 8, 2017 01:14
@mdo mdo mentioned this pull request Jan 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants