Fix incorrect docs.min.js bundle source. #21591

merged 1 commit into from Jan 8, 2017


None yet

2 participants


Errata from #21414. Fixes #21570. I misunderstood how the docs.min.js bundle worked, and included jQuery and Tether in it, which are already included in the page separately. Apparently Tether does not like being loaded twice. This was only detected when we shipped because that's the only time we compile the docs with github: true. Apologies for this mess up. 😕

@bardiharborow bardiharborow Fix incorrect docs.min.js bundle source.
@bardiharborow bardiharborow added this to the v4.0.0-beta milestone Jan 7, 2017
@bardiharborow bardiharborow requested a review from mdo Jan 7, 2017
mdo approved these changes Jan 7, 2017 View changes
@bardiharborow bardiharborow merged commit cdf7320 into twbs:v4-dev Jan 8, 2017

2 of 3 checks passed

savage Savage has initiated its special separate Travis CI build
continuous-integration/travis-ci/pr The Travis CI build passed
hound No violations found. Woof!
@bardiharborow bardiharborow deleted the bardiharborow:docs-uglify-fix branch Jan 8, 2017
@mdo mdo referenced this pull request Jan 8, 2017

Beta 1 ship list #21568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment