Fix JS components console error "Error: <Component> is transitioning" #21743

pvdlg · 2017-01-16T09:43:43Z

Fixes #21727

zcrwind · 2017-01-17T13:48:59Z

No violations found. Woof!

Nice work.

Johann-S

Great work @vanduynslagerp thank you 👍

gabrielkoerich · 2017-01-31T15:53:30Z

Will it be merged?

PlugIN73 · 2017-03-06T10:01:41Z

Good time to merge! ;)

jakeNiemiec · 2017-03-07T15:08:07Z

@PlugIN73 too bad Savage is taking so long.

jbutz · 2017-03-17T15:47:36Z

js/src/modal.js

@@ -162,16 +161,17 @@ const Modal = (($) => {
      }

      if (this._isTransitioning) {


@vanduynslagerp I think you should add a !this._isShown check here. If you don't and hide() is called when the modal is already hidden _isTransitioning is set to true and never reset to false.

Good catch ! Modification done. Thanks

mdo · 2017-03-20T16:21:44Z

@Johann-S @bardiharborow Is this PR good to merge over #21613? Seems this PR fixes the tooltip in modal issue (#21607), and other related transition issues as mentioned in #21727.

Johann-S · 2017-03-20T20:58:00Z

@mdo this PR do not fix the same issue as #21613. But yes the PR fix other issues related to #21727 (but not this one #21607)

dataflowjs · 2017-03-26T16:19:20Z

the some problem: github

alecpl · 2017-03-28T07:06:05Z

Would be nice to have popover fixed in the beta release, please.

…d the tooltip suddenly disappearing and reappearing when hovering on and off

…ethods

Johann-S · 2017-03-28T20:34:04Z

@vanduynslagerp I rebased your branch and now your branch is up to date. I'll review your code asap

Johann-S · 2017-03-28T21:08:17Z

It seems I cannot update your repository anymore, so can you update your branch and I'll merge because everything is fine @vanduynslagerp

CydGoblin · 2017-04-19T14:11:13Z

Does this apply to npm? I just downloaded it with npm and have this error.

Johann-S · 2017-04-19T14:12:43Z

You'll have this fix on the next release of BS4 @Turqueso not Alpha6

jakeNiemiec · 2017-04-19T18:12:42Z

@Turqueso And here is the progress for the next release just in case if you (like me) are eagerly waiting.

selfagency · 2017-05-15T23:59:02Z

I pulled the current v4-dev branch into a project in which I'm receiving a "collapse is transitioning" error (understrap/understrap-child#46) and the problem persists, even with this merge.

child-theme.min.js?ver=0.2.2:formatted:1876 Uncaught Error: Collapse is transitioning
    at a.show (child-theme.min.js?ver=0.2.2:formatted:1876)
    at a.toggle (child-theme.min.js?ver=0.2.2:formatted:1870)
    at HTMLDivElement.<anonymous> (child-theme.min.js?ver=0.2.2:formatted:1997)
    at Function.each (jquery.js?ver=1.12.4:2)
    at jQuery.fn.init.each (jquery.js?ver=1.12.4:2)
    at jQuery.fn.init.a._jQueryInterface [as collapse] (child-theme.min.js?ver=0.2.2:formatted:1987)
    at HTMLButtonElement.<anonymous> (child-theme.min.js?ver=0.2.2:formatted:2020)
    at HTMLDocument.dispatch (jquery.js?ver=1.12.4:3)
    at HTMLDocument.r.handle (jquery.js?ver=1.12.4:3)

child-theme.min.js is a concatenated version of bootstrap 4's js modules. You can see it here.

hernimen · 2017-06-12T18:38:51Z

still getting this error. Any idea?

Johann-S · 2017-06-12T18:41:43Z

This fix will be in our next release

selfagency · 2017-06-12T18:48:19Z

I was able to resolve this issue by removing hidden-md-down from my navbar-menu

ReSpawN · 2017-08-15T13:32:06Z

@Johann-S when is your next release scheduled? We're still using static shows instead of transitions/animations. We can merge and pull from this brand but we'd rather wait for a release from your end.

Johann-S · 2017-08-15T13:58:58Z

We shipped a release 4 days ago see : https://github.com/twbs/bootstrap/releases/tag/v4.0.0-beta or our blog

ReSpawN · 2017-08-15T21:54:22Z

Don't know how I missed that! I'll start implementation in the morning! Tx.

emmanueltouzery · 2017-08-18T07:42:17Z

beta fixed it for me

pvdlg mentioned this pull request Jan 16, 2017

JS components throws console error "Error: <Component> is transitioning" #21727

Closed

bardiharborow added js v4 labels Jan 17, 2017

bardiharborow self-assigned this Jan 17, 2017

pvdlg mentioned this pull request Jan 20, 2017

Clearer mentions of util.js #20660

Closed

pvdlg mentioned this pull request Jan 28, 2017

v4.0.0-alpha.6 - Activating tooltips breaks modals (stuck "transitioning") #21607

Closed

Johann-S approved these changes Jan 30, 2017

View reviewed changes

CorentinHcd mentioned this pull request Mar 13, 2017

<Component> is transitioning Orange-OpenSource/Orange-Boosted-Bootstrap#50

Closed

jbutz reviewed Mar 17, 2017

View reviewed changes

Johann-S mentioned this pull request Mar 24, 2017

Uncaught Error: Collapse is Transitioning #22256

Closed

pvdlg added 8 commits March 28, 2017 22:29

Revert twbs#17823

60f586b

Do not re-add the tooltip to the document if it’s already there. Avoi…

e4385f4

…d the tooltip suddenly disappearing and reappearing when hovering on and off

Make modal, like other component, ignore command when transitioning

5ff947d

Mention that JS methods are asynchronous in the Javascript docs

bf666f4

Fix mention of transition.js => util.js

ad1e413

Add callout for JS asynchronous modules

66a13fe

Add callout regarding async methods and add some details to some JS m…

c7e0bf6

…ethods

Close modal only if currently shown

02c63f5

Johann-S force-pushed the js-transitioning-1 branch from afdb14e to 02c63f5 Compare March 28, 2017 20:32

Johann-S mentioned this pull request Mar 28, 2017

Fix hide tooltip into a modal #21613

Closed

This was referenced Apr 26, 2017

[QUESTION] navbar open|close icon throw error "collapse is transitioning" #22527

Closed

Navbar Transition #22544

Closed

Tooltip error on mouseover #22555

Closed

Fix reopening modal when modal already active #21687

Closed

Johann-S mentioned this pull request May 4, 2017

V4 Alpha 6: Popover errors when using hover trigger #21600

Closed

selfagency mentioned this pull request May 12, 2017

JS error on mobile menu button understrap/understrap-child#46

Closed

typeplus mentioned this pull request May 21, 2017

Uncaught Error: Tooltip is transitioning understrap/understrap#326

Closed

Johann-S mentioned this pull request Jul 6, 2017

Hover on Tooltips within a Modal does not allow you to close the Modal afterwards #23003

Closed

JourneyToSilius mentioned this pull request Jul 19, 2017

Collapse is transitioning error Daemonite/material#134

Closed

This was referenced Jul 27, 2017

Carousel navigation problem (v4) #23165

Closed

[v4][examples] Modal not closing when tooltip hovered #23173

Closed

patrickhlauke mentioned this pull request Jul 30, 2017

Modal bug #23180

Closed

Johann-S mentioned this pull request Aug 2, 2017

Tooltips and popovers problem #23203

Closed

ppazos mentioned this pull request Aug 8, 2017

issue after resizing event and clicking on it ppazos/notes#35

Closed

Johann-S mentioned this pull request Aug 10, 2017

Bootstrap V4-aplha Carousel bug #23272

Closed

joriki mentioned this pull request Apr 8, 2019

Error: Tooltip is transitioning DemokratieInBewegung/plenum#311

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix JS components console error "Error: <Component> is transitioning" #21743

Fix JS components console error "Error: <Component> is transitioning" #21743

pvdlg commented Jan 16, 2017

zcrwind commented Jan 17, 2017

Johann-S left a comment

gabrielkoerich commented Jan 31, 2017

PlugIN73 commented Mar 6, 2017

jakeNiemiec commented Mar 7, 2017 •

edited

Loading

jbutz Mar 17, 2017

pvdlg Mar 20, 2017

mdo commented Mar 20, 2017

Johann-S commented Mar 20, 2017

dataflowjs commented Mar 26, 2017

alecpl commented Mar 28, 2017

Johann-S commented Mar 28, 2017

Johann-S commented Mar 28, 2017

CydGoblin commented Apr 19, 2017

Johann-S commented Apr 19, 2017

jakeNiemiec commented Apr 19, 2017

selfagency commented May 15, 2017

hernimen commented Jun 12, 2017

Johann-S commented Jun 12, 2017

selfagency commented Jun 12, 2017

ReSpawN commented Aug 15, 2017 •

edited

Loading

Johann-S commented Aug 15, 2017

ReSpawN commented Aug 15, 2017

emmanueltouzery commented Aug 18, 2017

		@@ -162,16 +161,17 @@ const Modal = (($) => {
		}

		if (this._isTransitioning) {

Fix JS components console error "Error: <Component> is transitioning" #21743

Fix JS components console error "Error: <Component> is transitioning" #21743

Conversation

pvdlg commented Jan 16, 2017

zcrwind commented Jan 17, 2017

Johann-S left a comment

Choose a reason for hiding this comment

gabrielkoerich commented Jan 31, 2017

PlugIN73 commented Mar 6, 2017

jakeNiemiec commented Mar 7, 2017 • edited Loading

jbutz Mar 17, 2017

Choose a reason for hiding this comment

pvdlg Mar 20, 2017

Choose a reason for hiding this comment

mdo commented Mar 20, 2017

Johann-S commented Mar 20, 2017

dataflowjs commented Mar 26, 2017

alecpl commented Mar 28, 2017

Johann-S commented Mar 28, 2017

Johann-S commented Mar 28, 2017

CydGoblin commented Apr 19, 2017

Johann-S commented Apr 19, 2017

jakeNiemiec commented Apr 19, 2017

selfagency commented May 15, 2017

hernimen commented Jun 12, 2017

Johann-S commented Jun 12, 2017

selfagency commented Jun 12, 2017

ReSpawN commented Aug 15, 2017 • edited Loading

Johann-S commented Aug 15, 2017

ReSpawN commented Aug 15, 2017

emmanueltouzery commented Aug 18, 2017

jakeNiemiec commented Mar 7, 2017 •

edited

Loading

ReSpawN commented Aug 15, 2017 •

edited

Loading