-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix border issue for nested card inside accordions #27881
Conversation
Hi @ovpv, Can you provide a demo to make clear what this fixes? |
The issue demo The fix demo @MartijnCuppens , In the above fix demo, you can see that the the |
Hi @ovpv, Thanks for the PR! If you open a PR which closes an issue, you can add Apart from that, this looks good! Thanks for the solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Thanks for the approval @MartijnCuppens . This is my first contribution on github! 😄 I will make sure that I add the necessary details for a PR in my future contributions 👍 |
It didn't solve everything. Please try this:
|
@osnofa you should probably make a new issue. |
After analysing the code in scss/_card.scss, in line 281, the styles added for .card class inside .accordian class is targeting all the cards inside instead of its immediate children elements with the class .card.
Code now:
Fix:
Fixes #27510, fixes #26556.