Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4 dev backports #29177

Merged
merged 13 commits into from
Aug 17, 2019
Merged

V4 dev backports #29177

merged 13 commits into from
Aug 17, 2019

Commits on Aug 10, 2019

  1. v4/v5: Add responsive containers (#29095)

    * create responsive containers
    
    provide more flexibility and allow the user to determine when containers switch from fluid to fixed width.
    
    * fix the base container code
    
    this commit fixes the non-media portion of the generated CSS. I learned about the `@extends` directive and was able to put it to good use.
    
    I create a new temporary map that contains all the main `$container-max-widths` and join it to our 2 special cases of 'xs' and 'fluid'.  Then we loop through that and, with the appropriate infixes, extend our placeholder
    
    * formatting for style
    
    forgot to run my tests before the last push, i think these are better.
    
    * finish incomplete comment
    
    * fix the responsive containers
    
    using the `@extend` directive I was able to clean up this code
    
    * fix responsive containers in the navbar
    
    mostly we just look through all of our breakpoints so we can include all of the responsive container classes in the tweaks we have to do for the navbar (redeclaring flex properties, don't double up on padding, etc)
    
    * Simplify container extends
    
    * Simplify navbar containers
    
    * Rearrange, add comments, ensure everything is nested in $enable-grid-classes
    
    * Reduce new CSS by using attribute selector
    
    We avoid using `@extend` whenever possible, and this is more readable
    
    * Update _grid.scss
    
    * Update _navbar.scss
    
    * Add docs for responsive containers, redesign the container layout page
    
    * Add to the Grid example
    mdo authored and XhmikosR committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    51efc88 View commit details
    Browse the repository at this point in the history
  2. fix broken classes

    mdo authored and XhmikosR committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    396e2d5 View commit details
    Browse the repository at this point in the history
  3. Extend .container-fluid (#29106)

    MartijnCuppens authored and XhmikosR committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    8b61085 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7933633 View commit details
    Browse the repository at this point in the history
  5. Responsive containers (follow-up to #29095) (#29118)

    * Follow-up to #29095
    
    This PR fixes the responsive containers that were added in #29095, originally stubbed out in #25631. Apologies to @browner12 for getting that wrong.
    
    Fixes #25631.
    
    * update navbar as well because we cannot reset all containers uniformly
    
    * Update navbars example to include container-xl example to ensure containers match
    
    * rewrite responsive containers docs, add table of max-widths
    
    * Update container docs
    - Move table up to the intro
    - Remove the container example because it's actually hella confusing
    - Update and link to grid example as a demo instead
    mdo authored and XhmikosR committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    00838d3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e5945ac View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f1e3480 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d6405c9 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2019

  1. Configuration menu
    Copy the full SHA
    7be98b5 View commit details
    Browse the repository at this point in the history
  2. Fix redirects. (#29254)

    XhmikosR committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    4756a8e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c62f04b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7b6b797 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ec8a4a7 View commit details
    Browse the repository at this point in the history