-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V4 dev backports #29177
Merged
Merged
V4 dev backports #29177
Commits on Aug 10, 2019
-
v4/v5: Add responsive containers (#29095)
* create responsive containers provide more flexibility and allow the user to determine when containers switch from fluid to fixed width. * fix the base container code this commit fixes the non-media portion of the generated CSS. I learned about the `@extends` directive and was able to put it to good use. I create a new temporary map that contains all the main `$container-max-widths` and join it to our 2 special cases of 'xs' and 'fluid'. Then we loop through that and, with the appropriate infixes, extend our placeholder * formatting for style forgot to run my tests before the last push, i think these are better. * finish incomplete comment * fix the responsive containers using the `@extend` directive I was able to clean up this code * fix responsive containers in the navbar mostly we just look through all of our breakpoints so we can include all of the responsive container classes in the tweaks we have to do for the navbar (redeclaring flex properties, don't double up on padding, etc) * Simplify container extends * Simplify navbar containers * Rearrange, add comments, ensure everything is nested in $enable-grid-classes * Reduce new CSS by using attribute selector We avoid using `@extend` whenever possible, and this is more readable * Update _grid.scss * Update _navbar.scss * Add docs for responsive containers, redesign the container layout page * Add to the Grid example
Configuration menu - View commit details
-
Copy full SHA for 51efc88 - Browse repository at this point
Copy the full SHA 51efc88View commit details -
Configuration menu - View commit details
-
Copy full SHA for 396e2d5 - Browse repository at this point
Copy the full SHA 396e2d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b61085 - Browse repository at this point
Copy the full SHA 8b61085View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7933633 - Browse repository at this point
Copy the full SHA 7933633View commit details -
Responsive containers (follow-up to #29095) (#29118)
* Follow-up to #29095 This PR fixes the responsive containers that were added in #29095, originally stubbed out in #25631. Apologies to @browner12 for getting that wrong. Fixes #25631. * update navbar as well because we cannot reset all containers uniformly * Update navbars example to include container-xl example to ensure containers match * rewrite responsive containers docs, add table of max-widths * Update container docs - Move table up to the intro - Remove the container example because it's actually hella confusing - Update and link to grid example as a demo instead
Configuration menu - View commit details
-
Copy full SHA for 00838d3 - Browse repository at this point
Copy the full SHA 00838d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5945ac - Browse repository at this point
Copy the full SHA e5945acView commit details -
Configuration menu - View commit details
-
Copy full SHA for f1e3480 - Browse repository at this point
Copy the full SHA f1e3480View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6405c9 - Browse repository at this point
Copy the full SHA d6405c9View commit details
Commits on Aug 16, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 7be98b5 - Browse repository at this point
Copy the full SHA 7be98b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4756a8e - Browse repository at this point
Copy the full SHA 4756a8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c62f04b - Browse repository at this point
Copy the full SHA c62f04bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b6b797 - Browse repository at this point
Copy the full SHA 7b6b797View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec8a4a7 - Browse repository at this point
Copy the full SHA ec8a4a7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.