-
-
Notifications
You must be signed in to change notification settings - Fork 78.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4: Add interaction utils #30562
v4: Add interaction utils #30562
Conversation
65426ff
to
8e05fca
Compare
Squashed the patches. TBH I'd prefer it if we didn't make it a new minor release. On the other hand, semver... Let's wait for the others to chime in. |
I agree |
Revisiting this, if @twbs/css-review is into it, I'm inclined to sneak this into v4.4.2 to help close the gap between v4 and v5. Really think this will be some solid good will for our users :). |
We never followed semver 100% and this, at least, is not a breaking change, so I think we can add it. |
I'm gonna stick with what I said in #30563 (comment). I don't want people to abuse this property. What I am willing to consider is adding
to reboot since this will be required anyway. |
That's a valid concern of course, but on the other hand, one can buy a gun legally (in some countries); if they kill someone the store cannot be held liable for any murders. 😇 But I definitely see your point. Maybe if we added a warning callout it'd be better? |
I'd be on both sides on this one:
|
Updated to reflect the team's feedback! Thanks y'all. |
Shouldn't Maybe even provide a sentence with explanation or link? |
- Adds .user-select-* utils from v5 - Adds button role attribute util, one of the top requested features in our issues for adding pointer cursors - Adds new docs page to demonstrate both - Includes Sass list for customizing user select
Think I got the feedback applied @MartijnCuppens and @ffoodd. Let me know with any suggested changes or review comments if there's something I can clarify more in the docs <3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We'll probably add some warning about the button role usage, but I think it's more @patrickhlauke's business here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI the utilities/interactions.scss wasn't included in utilities.scss. I fixed this in my v4-dev PR #30768. |
* v5: Add role=button cursor in Reboot Ports the changes from #30562 made in v4.5 and adds them to v5. This replaces #30563 which sought to add this to the utility API, but the v4 PR shifted to implement an accessible solution vs a lone utility. * Update reboot.md Co-authored-by: XhmikosR <xhmikosr@gmail.com>
* v5: Add role=button cursor in Reboot Ports the changes from twbs#30562 made in v4.5 and adds them to v5. This replaces twbs#30563 which sought to add this to the utility API, but the v4 PR shifted to implement an accessible solution vs a lone utility. * Update reboot.md Co-authored-by: XhmikosR <xhmikosr@gmail.com>
This might be overstepping things for our next v4 release, but I noticed how highly requested the
.cursor-pointer
utility was in #23709 and couldn't help but stub out a PR to address it. I've taken the v5 approach of an interactions page and included this new util, and theuser-select
one from v5. Decided not to includepointer-events
utils because of browser compatibility.I'd really like to ship small enhancements to v4 for folks with highly requested features like this, especially if it helps bridge the gap between v4 and v5. My biggest question is how we version/release this though.
Do we squeeze this into a v4.4.2 despite of it being a new feature and thus requiring a semver minor bump? Or do we upgrade v4.4.2 to v4.5?