V4 dev updates and backports #30768
Merged
V4 dev updates and backports #30768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
force-pushed
the
v4-dev-xmr
branch
2 times, most recently
from
7e26e3e
to
f06e8ed
Compare
mdo
approved these changes
May 11, 2020
Make the `docs-compile` one an alias of `docs-build`.
XhmikosR
force-pushed
the
v4-dev-xmr
branch
4 times, most recently
from
c3952cf
to
88a9aac
Compare
XhmikosR
commented
May 12, 2020
site/docs/4.4/components/forms.md
Outdated
| @@ -978,7 +978,7 @@ Validation styles are available for the following form controls and components: | |||
|
|
|||
| {% capture callout %} | |||
| ##### Input group validations | |||
| Input groups have difficulty with validation styles unfortunately. Our recommendation is to place feedback messages as sibling elements of the `.input-group` that has `.is-{valid|invalid}`. Placing feedback messages within input groups breaks the `border-radius`. [See this comment for workaround.](https://github.com/twbs/bootstrap/issues/25110#issuecomment-586565165) | |||
| Input groups have difficulty with validation styles, unfortunately. Our recommendation is to place feedback messages as sibling elements of the `.input-group` that has `.is-{valid|invalid}`. Placing feedback messages within input groups breaks the `border-radius`. [See this comment for a workaround](https://github.com/twbs/bootstrap/issues/25110#issuecomment-586565165). | |||
There was a problem hiding this comment.
@MartijnCuppens @mdo: I'm still not happy with us linking to a GitHub comment. We should move the workaround here.
XhmikosR
force-pushed
the
v4-dev-xmr
branch
3 times, most recently
from
e79048c
to
ad0ccd6
Compare
Johann-S
reviewed
May 12, 2020
XhmikosR
force-pushed
the
v4-dev-xmr
branch
3 times, most recently
from
5126f75
to
d0b8585
Compare
mdo
reviewed
May 12, 2020
While it might not be possible to invalidate the cache by changing test.yml, this should speed things up a lot due to `bundle i` taking most of the time.
* remove favicons meta tags * copy the two brand images we use in the examples * copy dist and brand images into an assets folder
Remove moot fail-fast option
We missed it in #30562
They are not included in npm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Preview: