-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean tooltip component unneeded functionality #32692
Conversation
So, basically this removes the ability to use the CSS classes for positioning the tooltips? Not sure I follow all the changes. @MartijnCuppens you recently had a look at popper too. |
This is the half truth ;) it still uses this: .bs-tooltip-auto {
&[data-popper-placement^="top"] {
@extend .bs-tooltip-top;
}
&[data-popper-placement^="right"] {
@extend .bs-tooltip-end;
}
&[data-popper-placement^="bottom"] {
@extend .bs-tooltip-bottom;
}
&[data-popper-placement^="left"] {
@extend .bs-tooltip-start;
}
} and as important on my opinion, it removes many of js, to be easier for future maintenance. This can do the difference too I only chose this solution as it pulls out some extra stuff |
0f2d321
to
1cbddbf
Compare
So, this patch still has the issue with tooltip randomly showing up in the wrong position when hovering fast, multiple times. But at least, it does show. |
If we remove the Also popper overrides the css properties |
@GeoSot @rohit2sharma95 What work remains here? I see tests are failing and we might still have the same issue with the fast hovering bug. Do we need to do something similar as #32843? Something else? |
I'm down to try anything at this point :). @rohit2sharma95 and @XhmikosR would know better what the implications of that might be though. |
I'm still seeing the issue with tooltip showing to the wrong position when hovering too fast. :/ |
@XhmikosR |
Confirmed, now it works! @rohit2sharma95 please review this, I added it in beta2 :) |
@GeoSot do the current tests in this branch catch this issue? We should make sure this doesn't happen again :) |
if you have any idea, how to do these tests, I would appreciate, any help or opinion |
Unfortunately, I don't know how either. Maybe @rohit2sharma95 can help us here? |
58e9a4c
to
dde15ec
Compare
120590e
to
a80005c
Compare
Remove a leftover after #32692 Co-authored-by: XhmikosR <xhmikosr@gmail.com>
) Regression of #32692 Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Preview: https://deploy-preview-32692--twbs-bootstrap.netlify.app/docs/5.1/components/tooltips/