Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiling with node-sass leads bad fonts file url contaning quotes #1574

Closed
3 tasks done
srad opened this issue Jan 18, 2023 · 2 comments · Fixed by #1566
Closed
3 tasks done

compiling with node-sass leads bad fonts file url contaning quotes #1574

srad opened this issue Jan 18, 2023 · 2 comments · Fixed by #1566

Comments

@srad
Copy link

srad commented Jan 18, 2023

Prerequisites

Describe the issue

Including the node_modules/bootstrap-icons/font/bootstrap-icons.scss and compiling with node-sass leads to quotes in the url("...") and the url is bad: /css/fonts/%22bootstrap-icons%22.woff2?24e3eb84d0bcaf83d77f904c78ac1f47

When I change this line:

$bootstrap-icons-font: "bootstrap-icons" !default;

to

$bootstrap-icons-font: bootstrap-icons !default;

The url is correct and can be loaded by the browser: /css/fonts/bootstrap-icons.woff2?24e3eb84d0bcaf83d77f904c78ac1f47

Reduced test cases

Install packages:

npm i bootstrap-icons
npm install node-sass

scss/main.scss file, include it:

@import "node_modules/bootstrap-icons/font/bootstrap-icons.scss";

Compile:

node-sass --output-style compressed -r scss/ -o css/

Include file in <link href="css/main.css"> and the font url is bad and cant be loaded by the browser:

/css/fonts/%22bootstrap-icons%22.woff2?24e3eb84d0bcaf83d77f904c78ac1f47

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome

What version of Bootstrap are you using?

v1.10.3

@mdo
Copy link
Member

mdo commented Jan 26, 2023

This repo is for Bootstrap, not Bootstrap Icons.

@mdo mdo transferred this issue from twbs/bootstrap Jan 26, 2023
@dherbst
Copy link
Contributor

dherbst commented Jan 26, 2023

PR #1566 should fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants