This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
Fallback to the node runner in ahc-link --run
#122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we introduced an inline-js runner for wasm/js generated by
ahc-link
, and enabled it as the default when runningahc-link --run
for inputs without custom entry module. However, in practice it seems the inline-js runner produces poorer error messages than the previous node runner.Now, we still use the old node runner for all
ahc-link --run
calls, and the inline-js runner is still preserved in thenomain
unit test & the experimental TH splice runner on thewip-jsrun
branch.