Build with ghc-8.9 + linear types patch #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facundominguez
force-pushed
the
fd/ghc-8.9
branch
from
fd2dac1
to
11d20fe
Compare
facundominguez
commented
Jul 12, 2019
| @@ -18,15 +18,20 @@ source-repository head | |||
| location: https://github.com/tweag/inline-java | |||
| subdir: jni | |||
|
|
|||
| flag ghc-head | |||
There was a problem hiding this comment.
Using impl(ghc > 8.9) instead of a flag, would probably cause the package to not build when ghc-8.9 is finally released.
The flag makes it more evident to users and build tools that the code we have here is only a transient solution for testing.
inline-java.cabal uses impl(ghc >= 8.9) because the code there is likely to remain valid.
facundominguez
force-pushed
the
fd/ghc-8.9
branch
4 times, most recently
from
1ba6e37
to
eb34807
Compare
facundominguez
force-pushed
the
fd/ghc-8.9
branch
from
eb34807
to
ee5af09
Compare
facundominguez
force-pushed
the
fd/ghc-8.9
branch
from
ee5af09
to
7381f14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.