Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove runInAttachedTread from reifyMVector (closes #152) #153

Merged
merged 8 commits into from
Sep 4, 2020
Merged

Remove runInAttachedTread from reifyMVector (closes #152) #153

merged 8 commits into from
Sep 4, 2020

Conversation

facundominguez
Copy link
Member

... and does some other refactorings. See the individual commits.

nbacquey
nbacquey reviewed Sep 4, 2020
View reviewed changes
Copy link
Member

@nbacquey nbacquey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See individual comments.
I didn't thoroughly review jni/src/common/Foreign/JNI/Internal/RWLock.hs,
as it seems to only be a move.

jni/src/common/Foreign/JNI/Internal/BackgroundWorker.hs Show resolved Hide resolved
jni/src/common/Foreign/JNI/Unsafe.hs Outdated Show resolved Hide resolved
jni/src/common/Foreign/JNI/Unsafe.hs Show resolved Hide resolved
@facundominguez facundominguez merged commit e09af58 into master Sep 4, 2020
@facundominguez facundominguez deleted the fd/finalizer-thread branch September 4, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbacquey nbacquey nbacquey left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@facundominguez @nbacquey