-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use acorn for parsing JavaScript code #87
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to use
language-javascript
for lexing or parsing JavaScript. This works for most cases, but the parser has rough edges (e.g. see #84 #86), and if we only do lexing, we don't have sufficient info about the AST (is it just an expression? is there top-levelawait
?).This PR switches to
acorn
for compile-time analysis of the inline JavaScript code in the quasiquoter.inline-js
embeds a 108K bundled JS file, and use that for analysis. The source code for producing the bundle is also included.The upsides of moving to
acorn
are:acorn
is a much more battle-tested JavaScript parser.expr
/block
quoters, thenjs
/jsAsync
. Now, we can finally only keep a singlejs
quoter which supports all use cases.The downside are:
node
at compile-time. Can be bad for a variety of reasons: bad for cross compilation; may be risky; may be slow.Anyway, let's make the switch since this is something I've wanted to do for a long time.
Also sneaks in some other changes:
cabal
for testing on WindowsClose #84 #86