Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert notebooks to html automatically #304

Merged
merged 6 commits into from
Oct 4, 2023
Merged

Conversation

turion
Copy link
Collaborator

@turion turion commented Aug 11, 2023

Supersedes #302 .

This PR builds the *.html files from the notebooks and compares them to the checked in files. So if there are notebook changes, CI forces you to regenerate the *.html.

@turion
Copy link
Collaborator Author

turion commented Aug 11, 2023

@idontgetoutmuch @reubenharry can you review?

@turion turion force-pushed the dev_notebooks_html branch 5 times, most recently from 1211fc8 to 38500f3 Compare October 2, 2023 16:09
@turion turion force-pushed the dev_notebooks_html branch 2 times, most recently from e30fabc to c802c3f Compare October 2, 2023 17:00
A few haskell packages can't be built,
so some notebooks will not compile.
Still, we're in a better place than before.

Further, I had to remove haskell-flake-utils,
it seems not to be supported sufficiently.
This dropped cabal-docspec support.

I also had to remove the nixpkgs follow input,
otherwise there would be an infinite loop:
(tweag/jupyenv#525)
@turion turion merged commit d2f658c into master Oct 4, 2023
5 checks passed
@turion turion deleted the dev_notebooks_html branch October 4, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants