Special syntax for fully-applied primitive operations #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
yannham
force-pushed
the
task/primitive-operators-representation
branch
from
e1cb155
to
9fb8df7
Compare
aspiwack
approved these changes
Dec 17, 2020
Comment on lines
+195
to
+199
| self.load_stdlib( | ||
| "<stdlib/records.ncl>", | ||
| nickel_stdlib::RECORDS, | ||
| &mut global_env, | ||
| )?; |
There was a problem hiding this comment.
Maybe stdlib.rs should export a list of all its Nickel modules. I feel that it's rather impractical to have to add said modules in two different files.
There was a problem hiding this comment.
True. I'm currently reworking the program module to prepare for the REPL anyway, I will do that.
| concat : List -> List -> List = fun l1 l2 => l1 @ l2; | ||
|
|
||
| foldl : forall a. (a -> Dyn -> a) -> a -> List -> a = | ||
| fun f fst l => | ||
| if length l == 0 then | ||
| if %length% l == 0 then |
There was a problem hiding this comment.
Unrelated to this PR, but I hope that %length% l is O(1). Otherwise foldl (and fold) as written here is quadratic.
There was a problem hiding this comment.
Yes, list are currently implemented as vectors so length is O(1). I suspect this was written because at that time equality was implemented only for numbers though, so l == [] is probably more future-proof.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #228. Use a specific syntax for fully applied built-in operators,
%operator%, and wrap this primitive version in vanilla functions of the standard library.This has the unfortunate consequence described in #226, that is that wrapped operator does not behave as unwrapped operator with respect to typing, but this is a separate topic that needs to be addressed anyway.
This also led to #244. This PR currently assigns correct but less ergonomic types - the ones with
Dyn- to primitive operators wrapped in the standard library, while the actual primitive ones stay polymorphic. We'll have to resolve this discrepancy together with #244.