Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort language pragmas #147

Merged
merged 1 commit into from
Jul 5, 2019
Merged

Sort language pragmas #147

merged 1 commit into from
Jul 5, 2019

Conversation

waddlaw
Copy link
Contributor

@waddlaw waddlaw commented Jul 1, 2019

Close #20.

@mrkkrp
Copy link
Member

mrkkrp commented Jul 2, 2019

We're trying to figure out why CI fails for some users. Could you log in into CircleCI and try to click the "restart job" button there and see what happens?

@waddlaw
Copy link
Contributor Author

waddlaw commented Jul 3, 2019

"restart job" button does not appear. "An unauthorized user error" has occurred.

ci

@aspiwack
Copy link
Member

aspiwack commented Jul 3, 2019

Thanks for the screenshot: it's very helpful! We'll try to figure out how to fix this.

@mrkkrp
Copy link
Member

mrkkrp commented Jul 4, 2019

Apparently for some users CI works, see for example #150 which worked right away. We're puzzled by the behavior. To move forward with the PR, I'm going to restart the build myself.

@mrkkrp
Copy link
Member

mrkkrp commented Jul 4, 2019

I'm going to amend this work in order to implement everything mentioned in #20 because it makes sense to handle everything now instead of going back and forth with this.

@mrkkrp
Copy link
Member

mrkkrp commented Jul 4, 2019

I couldn't finish this this evening, but the idea here is to extract collection of extensions in a typed way and drop them from raw comments. Then we can just pretty-print the extensions so they have 1) fixed placement relative to other constructs such as module header 2) always totally normalized.

Will return to this when I have time.

The approach we take here is parsing of language pragmas on creation of
comment stream and then pretty-printing them in a separate block.
@mrkkrp mrkkrp merged commit ae40a33 into tweag:master Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement automatic sorting of language pragmas
3 participants