Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate ahc.BUILD.tpl file for asterius. #1660

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Conversation

ylecornec
Copy link
Member

Before this PR, the same ghc.BUILD.tpl file was used for both asterius and regular haskell toolchain, but now the asterius one uses a new ahc.BUILD.tpl file.

Most notably, this prevents loading the @rules_haskell//haskell/asterius:defs.bzl file when it is not needed, which is what seems to be happening in issue #1635.

Copy link
Member

@aherrmann aherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aherrmann aherrmann added the merge-queue merge on green CI label Dec 10, 2021
@mergify mergify bot merged commit b9fe31d into master Dec 10, 2021
@mergify mergify bot deleted the ylecornec/ahc_build_tpl branch December 10, 2021 15:26
@mergify mergify bot removed the merge-queue merge on green CI label Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants