Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append scope to node before annotation #577

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Append scope to node before annotation #577

merged 1 commit into from
Jul 13, 2023

Conversation

ErinvanderVeen
Copy link
Member

Resolves #571 by only checking if the annotation itself started on a new line rather than the entire node before it.

@ErinvanderVeen
Append scope to node before annotation
243b62a 
Resolves #571 by only checking if the annotation itself started on a new line
vkleen
vkleen approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@vkleen vkleen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solves the issue with formatting in the Nickel repo 👍

@ErinvanderVeen ErinvanderVeen merged commit 322ff5a into main Jul 13, 2023
4 checks passed
@ErinvanderVeen ErinvanderVeen deleted the 571-nickel-formatting-regression branch July 13, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkleen vkleen vkleen approved these changes

@nbacquey nbacquey nbacquey approved these changes

@torhovland torhovland Awaiting requested review from torhovland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nickel formatting regression
3 participants
@ErinvanderVeen @vkleen @nbacquey