Skip to content
This repository has been archived by the owner on Apr 2, 2023. It is now read-only.

Working with ES6 classes, iterable properties and other 'modern JavaScript' stuff #4

Closed
sole opened this issue Oct 3, 2016 · 2 comments

Comments

@sole
Copy link
Member

sole commented Oct 3, 2016

People want to use 'modern JavaScript' with tween.js but some things just don't quite work as you would expect. Sometimes it is due to the way we iterate before deciding which properties to tween, other times it's a consequence of how classes are not 'exactly' objects so things are not iterable. Other times it might be a consequence of transpilers rewriting code so what you see isn't exactly what tween.js sees.

The end result is that things do not work as you expect them to work, which isn't good.

(some) related issues:
tweenjs/tween.js#287
tweenjs/tween.js#267

@dalisoft
Copy link

@sole please look at here and here. i hope you like it

@trusktr
Copy link
Member

trusktr commented Oct 26, 2020

We've got modern syntax now, and it is also now TypeScript. I think we can close this discussion, and open any new one based on the latest code.

@trusktr trusktr closed this as completed Oct 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants