Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link fields design is incorrect. #2972

Closed
Bonapara opened this issue Dec 13, 2023 · 4 comments
Closed

Link fields design is incorrect. #2972

Bonapara opened this issue Dec 13, 2023 · 4 comments
Assignees
Labels

Comments

@Bonapara
Copy link
Member

Bonapara commented Dec 13, 2023

Current behavior

The link field design looks like a regular text field:

Index page:

Screenshot 2023-12-13 at 12 06 06

Show page:

Screenshot 2023-12-13 at 12 12 46

Desired behavior

Put the link in the link field type on both index & show:

Index:

Screenshot 2023-12-13 at 12 07 26

Screenshot 2023-12-13 at 12 04 55

https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?type=design&node-id=14603-76540&mode=design&t=pfE2hTyckvmdvs26-11

Show:

Screen.Recording.2023-12-13.at.12.09.36.mov

Screenshot 2023-12-13 at 12 08 40

https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?type=design&node-id=14603-76540&mode=design&t=pfE2hTyckvmdvs26-11

@Bonapara Bonapara added scope: front Issues that are affecting the frontend side only for experienced contributor labels Dec 13, 2023
@Kanav-Arora
Copy link
Contributor

Hi @Bonapara
I can work on this

@Bonapara
Copy link
Member Author

Sure, thanks @Kanav-Arora ;)

@charlesBochet
Copy link
Member

@Bonapara @Kanav-Arora this is not a link field currently, this is a text field.
We will actually need to migrate this to a Link field but we are holding as we don't support array fields for now (as we would need to properly implement domain names).
What you can do for now @Kanav-Arora is to introduce a DomainFieldInput and DomainFieldDisplay and to conditionnally use it if fieldName = 'domainName' and objectMetadataSingularName = 'company' in FieldDisplay and FieldInput components
We do that for phone and email that are not implemented yet either

Long term what we want:

  • migrate it to link once array fields are supported + we know how to smoothly migrate existing workspaces
  • treat this as a LinkField with option isDomain

@FelixMalfait
Copy link
Member

Closing because there is now #3607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

4 participants