Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate field type probability to rating #3531

Closed
FelixMalfait opened this issue Jan 18, 2024 · 2 comments
Closed

Migrate field type probability to rating #3531

FelixMalfait opened this issue Jan 18, 2024 · 2 comments
Assignees
Labels

Comments

@FelixMalfait
Copy link
Member

I saw in the code we have a field type "probability":

I don't think we should have both Probability and Rating. We should only keep one field type (probability)

Eventually this field type could have additional options to customize the display and values in the future

@charlesBochet
Copy link
Member

Let's remove it!

@FelixMalfait
Copy link
Member Author

OK I think this should be very quick (just a few lines of code to delete?), it doesn't seem to be used.

But Opportunity probability used to be of type rating I think? And now it's just a basic string? we should fix this and bring it back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants
@FelixMalfait @charlesBochet @CoreTeamTwenty and others