Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New "inverted" Background Colors #4726

Closed
Tracked by #4723
Bonapara opened this issue Apr 1, 2024 · 8 comments
Closed
Tracked by #4723

New "inverted" Background Colors #4726

Bonapara opened this issue Apr 1, 2024 · 8 comments
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only

Comments

@Bonapara
Copy link
Member

Bonapara commented Apr 1, 2024

Desired Behavior

We want to introduce 2 new Inverted background colors in the theme:

Inverted - Secondary
Inverted - Primary

Inverted - Secondary will be used as the gray Neutral banner background.

Properties

CleanShot 2024-04-01 at 11 38 47@2x
@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: minutes labels Apr 1, 2024
@Bonapara Bonapara mentioned this issue Apr 1, 2024
Closed
@shree-1788
Copy link
Contributor

@Bonapara can you assign me this issue?

@Bonapara
Copy link
Member Author

Bonapara commented Apr 1, 2024

Sure, thanks @shree-1788!

@Bonapara Bonapara added the UI label Jul 1, 2024
@DecodersLord
Copy link
Contributor

@Bonapara Would love to take a look into this.. can you please provide a bit more info?

@Bonapara
Copy link
Member Author

The goal is to introduce these 2 new colors in the design system :)

@DecodersLord
Copy link
Contributor

DecodersLord commented Jul 19, 2024 •
edited
Loading

@Bonapara I guess I have made the correct changes by editing BackgroundLight and BackgroundDarak files as below

image

However, when trying to build twenty-ui using npx I run into below error on my WSL 2 Ubuntu machine. Is it just my machine or I am missing any pre-requisites? (All the build requirements before this works and I can even hit the server at http://localhost:3000/graphql.)

image

The test twenty-ui passes but I guess that doesn't necessarily test the changes
image

@DecodersLord
Copy link
Contributor

I see #6329 reporting the same but with no resolution.

@Bonapara
Copy link
Member Author

@lucasbordeau any input?

@ijreilly ijreilly mentioned this issue Jul 22, 2024
Merged
@ijreilly
Copy link
Collaborator

ijreilly commented Jul 22, 2024 •
edited
Loading

Fixed with #6354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only
Projects
Product development ✅
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DecodersLord @Bonapara @ijreilly @shree-1788