Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task name input field is buggy #5077

Closed
orinamio opened this issue Apr 21, 2024 · 2 comments
Closed

Task name input field is buggy #5077

orinamio opened this issue Apr 21, 2024 · 2 comments
Labels
type: bug Something isn't working

Comments

@orinamio
Copy link
Contributor

orinamio commented Apr 21, 2024

Bug Description

When creating a task, the name field behaves in unexpected ways. The bug is visible when you try to clear the inputed text completely and it flickers. You need to press the backspace button a few times before the text is completely cleared.

task_name_input_bug.mov

Expected behavior

Clearing the input text for task name should be a smooth experience.

Technical inputs

This bug seems to be an accidental react state update bug.

@orinamio orinamio added the type: bug Something isn't working label Apr 21, 2024
@AlexVascon
Copy link

I can take a look at this

@AlexVascon
Copy link

Ok I spent some time on this. I did make a PR but I admit it's not a permanent solution.

The PR can be found here: #5080 with all the details.

To summarise the issue is in the ActivityTitle.tsx file. In the handleTitleChange handler the title input gets cached and based on the setTimeOut settings the cached input will replace the deleted input. Resetting the time out to 0 prevents that problem. This way there is not a delay and old data removed does not suddenly reappear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants