fix(select): background color in dark mode on windows (#3110)

* fix(select): background color in dark mode on windows * fix: inherit solid color * fix: background for inverse
twilio-labs · Mar 28, 2023 · ac5a844 · ac5a844
1 parent 1a70c27
commit ac5a844
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/.changeset/strange-spoons-hear.md b/.changeset/strange-spoons-hear.md
@@ -0,0 +1,6 @@
+---
+'@twilio-paste/select': patch
+'@twilio-paste/core': patch
+---
+
+[Select] Fixed a bug in dark mode on Windows where the options list was still white and the options were unreadable
diff --git a/packages/paste-core/components/select/src/Select.tsx b/packages/paste-core/components/select/src/Select.tsx
@@ -33,7 +33,8 @@ export const SelectElement = React.forwardRef<HTMLSelectElement, SelectProps>(
          */
         height={undefined}
         appearance="none"
-        backgroundColor="transparent"
+        // must set a solid color to inherit in options for Windows
+        backgroundColor={variant === 'inverse' ? 'colorBackgroundInverse' : 'colorBackgroundBody'}
         border="none"
         borderRadius="borderRadius20"
         boxShadow="none"