fix(select): background color in dark mode on windows #3110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d292fe0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
the
Area: Components
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Passing run #5680 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d292fe0:
|
|
Size Change: +8 B (0%) Total Size: 976 kB
ℹ️ View Unchanged
|
nkrantz
previously approved these changes
Mar 21, 2023
SiTaggart
added
🚀 merge it!
🕵🏻♀️ Run website visual regression
github-actions
bot
added
Area: Core bundle
Area: Layout
Area: Primitives
Area: Repo
Area: Theme
SiTaggart
force-pushed
the
fix/select-windows-darkmode
branch
from
5e7efdd
to
ba15f72
Compare
github-actions
bot
removed
Area: Core bundle
Area: Repo
Area: Theme
loreina
previously approved these changes
Mar 22, 2023
nkrantz
previously approved these changes
Mar 23, 2023
SiTaggart
added
Status: Do Not Merge
SiTaggart
commented
Mar 23, 2023
SiTaggart
added
🚀 merge it!
and removed
Status: Do Not Merge
Merged
raffaele-abramini
pushed a commit
that referenced
this pull request
Jan 26, 2024
* fix(select): background color in dark mode on windows * fix: inherit solid color * fix: background for inverse (cherry picked from commit ac5a844)
SiTaggart
added a commit
that referenced
this pull request
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2909
Changes in this PR:
Control background color of options
In windows we need to explicitly set the background color of options, otherwise in dark mode its white on white bg
Checklist
requiredchecks have passed🕵🏻♀️ Run website visual regressionlabelContributing to Twilio