fix(input): allow input to work with hook form library #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richbachman
added
the
Area: Components
🦋 Changeset detectedLatest commit: 8f45e84 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). paste – ./🔍 Inspect: https://vercel.com/twilio-dsys/paste/BzCV8F9TYixMaCptubSPPmdDuKDJ paste-theme-designer – ./🔍 Inspect: https://vercel.com/twilio-dsys/paste-theme-designer/8koFNzZak1dcwbH9A1jfD8a7Lhbn |
|
@vnguyen94 these are the initial code changes I found. Let me know if there's anything you that I'm missing. Thanks! |
|
Size Change: -45 B (0%) Total Size: 513 kB
ℹ️ View Unchanged
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
richbachman
force-pushed
the
form-hook-changes
branch
from
e6d0c9f
to
3bed996
Compare
richbachman
force-pushed
the
form-hook-changes
branch
from
3bed996
to
6be1459
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8f45e84:
|
TheSisb
approved these changes
Mar 8, 2021
richbachman
force-pushed
the
form-hook-changes
branch
from
6be1459
to
8f45e84
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to form components that allow components to work with hook form libraries like: https://github.com/vnguyen94/react-hook-form-paste