Feat/stack customization #1722
Merged
Feat/stack customization #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zahnster
commented
Aug 2, 2021
zahnster
commented
- Enable stack and stack children to respect element customizations set on the customization provider.
- Stack and stack children now enable setting an element name on the underlying HTML element, and checks the emotion theme object to determine whether it should merge in custom styles to the ones set by the component author.
- Stories and tests added to support this change
🦋 Changeset detectedLatest commit: f3b3e7c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✔️ Deploy Preview for paste-docs ready! 🔨 Explore the source changes: f3b3e7c 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-docs/deploys/6109642b257771000772dc35 😎 Browse the preview: https://deploy-preview-1722--paste-docs.netlify.app |
|
Size Change: +80 B (0%) Total Size: 617 kB
ℹ️ View Unchanged
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f3b3e7c:
|
nkrantz
reviewed
Aug 2, 2021
| Stack.propTypes = { | ||
| orientation: ResponsiveProp(PropTypes.oneOf(['horizontal', 'vertical'])).isRequired, | ||
| spacing: isSpaceTokenProp, | ||
| element: PropTypes.string, |
There was a problem hiding this comment.
Question here, looks like element wasn't added to Media Object's propTypes in that PR. Should it have been, or is this unnecessary?
gloriliale
reviewed
Aug 2, 2021
| {validChildren.map((child, index) => { | ||
| return ( | ||
| <Box | ||
| element={`${element}_CHILD`} |
There was a problem hiding this comment.
I'm not sure I understand why we're giving the children an element prop. Wouldn't all of the children have the same name as the parent element and therefore all be styled the same?
There was a problem hiding this comment.
It creates an element name for the child based on the parent element name, but not exactly the same.
So yes, child elements have the same name, but it is different to the parent. It's potentially easier to see here in the tests https://github.com/twilio-labs/paste/pull/1722/files#diff-160e3be247ff4ca5d35a10f9e526e4cf0aa098b6b43b134a322e93e3c2ab75a4R159
SiTaggart
reviewed
Aug 2, 2021
@nkrantz 100% correct. Well spotted |
SiTaggart
approved these changes
Aug 2, 2021
nkrantz
approved these changes
Aug 3, 2021
richbachman
approved these changes
Aug 3, 2021
zahnster
force-pushed
the
feat/stack-customization
branch
from
cc3188c
to
f3b3e7c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.