Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ComponentHeader component, component overview fixes, more #20
feat: ComponentHeader component, component overview fixes, more #20
Changes from 25 commits
fef9c5c
e980d8c
d96bae7
6142e07
c97bc13
3a32390
94a00f9
eb01bd2
d141cda
f507329
46dd2bd
3c1bcde
073ba2c
d23baba
1348c90
05b2270
a408588
5fc7791
e9950f8
8dd11b2
419ddce
ccf8136
b15d3d8
1309998
97cd89a
aa7344a
4726f9a
a6bf2eb
917b994
974ef53
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you write a TODO here to convert these to tokens? line-heights are coming and font-size should already cover it.
Also is the height going to cause a problem if you bump the base font size for the page? Will the font scale (when using rems from tokens) and the fixed height cause issues?