Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Flex): add Flex component package #204

Merged
merged 28 commits into from
Dec 13, 2019
Merged

feat(Flex): add Flex component package #204

merged 28 commits into from
Dec 13, 2019

Conversation

richbachman
Copy link
Contributor

@richbachman richbachman commented Nov 26, 2019 •
edited
Loading

  • Flex component package
  • Flex stories
  • Flex unit and snapshot tests

@richbachman richbachman added Status: WIP This PR is still a work-in-progress. No need to review. Area: Components Related to the component library (core) of this system labels Nov 26, 2019
@vercel
Copy link

vercel bot commented Nov 26, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/twilio-dsys/paste/ot54h9qut
🌍 Preview: https://paste-git-flex-add-component.twilio-dsys.now.sh

@vercel vercel bot temporarily deployed to staging December 3, 2019 16:20 Inactive
TheSisb
TheSisb reviewed Dec 5, 2019
View reviewed changes
Copy link
Contributor

@TheSisb TheSisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. Super close to the finish line!

packages/paste-core/utilities/flex/src/index.tsx Outdated Show resolved Hide resolved
packages/paste-core/utilities/flex/src/index.tsx Outdated Show resolved Hide resolved
packages/paste-core/utilities/flex/src/index.tsx Outdated Show resolved Hide resolved
packages/paste-core/utilities/flex/src/index.tsx Show resolved Hide resolved
packages/paste-core/utilities/flex/src/index.tsx Outdated Show resolved Hide resolved
packages/paste-core/utilities/flex/src/index.tsx Outdated Show resolved Hide resolved
packages/paste-core/utilities/flex/src/index.tsx Outdated Show resolved Hide resolved
packages/paste-core/utilities/flex/src/index.tsx Outdated Show resolved Hide resolved
packages/paste-core/utilities/flex/src/index.tsx Outdated Show resolved Hide resolved
packages/paste-core/utilities/flex/stories/index.stories.tsx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to staging December 6, 2019 00:03 Inactive
TheSisb
TheSisb reviewed Dec 6, 2019
View reviewed changes
Copy link
Contributor

@TheSisb TheSisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing stories and tests, but the component is looking great!

TheSisb
TheSisb reviewed Dec 10, 2019
View reviewed changes
packages/paste-core/utilities/flex/__tests__/flex.test.tsx Show resolved Hide resolved
packages/paste-core/utilities/flex/src/index.tsx Outdated Show resolved Hide resolved
packages/paste-core/utilities/flex/src/index.tsx Outdated Show resolved Hide resolved
packages/paste-core/utilities/flex/src/index.tsx Outdated Show resolved Hide resolved
packages/paste-core/utilities/flex/src/index.tsx Outdated Show resolved Hide resolved
packages/paste-core/utilities/flex/src/index.tsx Outdated Show resolved Hide resolved
packages/paste-core/utilities/flex/src/index.tsx Show resolved Hide resolved
packages/paste-core/utilities/flex/src/index.tsx Show resolved Hide resolved
packages/paste-core/utilities/flex/src/index.tsx Show resolved Hide resolved
packages/paste-core/utilities/flex/src/index.tsx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to staging December 11, 2019 03:52 Inactive
@richbachman richbachman added Status: Pls CR This PR is ready for Code Reviews and removed Status: WIP This PR is still a work-in-progress. No need to review. labels Dec 11, 2019
TheSisb
TheSisb approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@TheSisb TheSisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent work! Can't wait to use this 👍

@richbachman richbachman merged commit 74877c4 into master Dec 13, 2019
@richbachman richbachman deleted the flex/add-component branch December 13, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiTaggart SiTaggart SiTaggart left review comments

@TheSisb TheSisb TheSisb approved these changes

Assignees
No one assigned
Labels
Area: Components Related to the component library (core) of this system Status: Pls CR This PR is ready for Code Reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richbachman @SiTaggart @TheSisb