Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Flex): add Flex component package #204

Merged
merged 28 commits into from Dec 13, 2019
Merged

feat(Flex): add Flex component package #204

merged 28 commits into from Dec 13, 2019

Conversation

@richbachman
Copy link
Collaborator

richbachman commented Nov 26, 2019

  • Flex component package
  • Flex stories
  • Flex unit and snapshot tests
@TheSisb

This comment has been minimized.

Copy link
Collaborator Author

TheSisb commented on packages/paste-types/src/style-props/flexbox.ts in f7e41d7 Nov 20, 2019

The reason I had to blow this out is because a lot of these rules under FlexboxProps previously had an | string appended, which basically made any typings moot. Every time you hovered over the prop in VS code it would result in just string typing because that was the broadest option. Not liking that, I copied a bunch of the rules over and omit the string option.

@now

This comment has been minimized.

Copy link

now bot commented Nov 26, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/twilio-dsys/paste/ot54h9qut
🌍 Preview: https://paste-git-flex-add-component.twilio-dsys.now.sh

@now now bot had a problem deploying to staging Nov 26, 2019 Failure
@now now bot temporarily deployed to staging Dec 3, 2019 Inactive
@now now bot had a problem deploying to staging Dec 3, 2019 Failure
Copy link
Collaborator

TheSisb left a comment

This is looking great. Super close to the finish line!

packages/paste-core/utilities/flex/src/index.tsx Outdated Show resolved Hide resolved
packages/paste-core/utilities/flex/src/index.tsx Outdated Show resolved Hide resolved
packages/paste-core/utilities/flex/src/index.tsx Outdated Show resolved Hide resolved
packages/paste-core/utilities/flex/src/index.tsx Outdated Show resolved Hide resolved
packages/paste-core/utilities/flex/src/index.tsx Outdated Show resolved Hide resolved
packages/paste-core/utilities/flex/src/index.tsx Outdated Show resolved Hide resolved
packages/paste-core/utilities/flex/src/index.tsx Outdated Show resolved Hide resolved
packages/paste-core/utilities/flex/src/index.tsx Outdated Show resolved Hide resolved
@now now bot had a problem deploying to staging Dec 5, 2019 Failure
@now now bot temporarily deployed to staging Dec 6, 2019 Inactive
Copy link
Collaborator

TheSisb left a comment

Still missing stories and tests, but the component is looking great!

@now now bot had a problem deploying to staging Dec 9, 2019 Failure
@now now bot had a problem deploying to staging Dec 10, 2019 Failure
@now now bot temporarily deployed to staging Dec 11, 2019 Inactive
Copy link
Collaborator

TheSisb left a comment

This is excellent work! Can't wait to use this 👍

@richbachman richbachman merged commit 74877c4 into master Dec 13, 2019
8 checks passed
8 checks passed
Semantic Pull Request ready to be squashed
Details
ci/circleci: applitools Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
now Deployment has completed
Details
scm/applitools No baseline conflicts found! (20 changes found)
Details
tests/applitools All visual tests passed! (54 tests)
Details
@richbachman richbachman deleted the flex/add-component branch Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.