fix(checkbox): hide icon when not checked #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 408fb00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Area: Components
|
✔️ Deploy Preview for paste-theme-designer ready! 🔨 Explore the source changes: 408fb00 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-theme-designer/deploys/6201b182c873a08ea9438ed6 😎 Browse the preview: https://deploy-preview-2167--paste-theme-designer.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 408fb00:
|
|
✔️ Deploy Preview for paste-docs ready! 🔨 Explore the source changes: 408fb00 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-docs/deploys/6201b189df6685949dc8dc1c 😎 Browse the preview: https://deploy-preview-2167--paste-docs.netlify.app |
|
Size Change: +62 B (0%) Total Size: 459 kB
ℹ️ View Unchanged
|
shleewhite
commented
Jan 29, 2022
packages/paste-core/components/checkbox/stories/checkbox.stories.tsx
Outdated
Show resolved
Hide resolved
zahnster
approved these changes
Jan 29, 2022
SiTaggart
reviewed
Jan 29, 2022
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
shleewhite
force-pushed
the
fix/checkbox-icon-hide
branch
from
252351a
to
1ef56cd
Compare
andioneto
reviewed
Feb 1, 2022
packages/paste-core/components/checkbox/stories/checkbox.stories.tsx
Outdated
Show resolved
Hide resolved
github-actions
bot
added
Area: Doc Site
shleewhite
commented
Feb 2, 2022
shleewhite
commented
Feb 2, 2022
| const handleChange = props.onChange != null ? props.onChange : checkboxGroupContext.onChange; | ||
|
|
||
| // Manages what the value of checked is depending on if it is controlled or uncontrolled | ||
| const [checkedState, setCheckedState] = React.useState(!!defaultChecked); |
There was a problem hiding this comment.
This is a simplified version of what Chakra does (see their useCheckbox hook)
If the user passes checked & onChange it is a controlled component, if they don't pass them it is uncontrolled.
There was a problem hiding this comment.
because defaultChecked is a boolean, what's the difference between using the double bang operator and just saying useState(defaultChecked)? wouldn't that still give you either true or false?
There was a problem hiding this comment.
It forces the value to always be a T/F. So, if defaultChecked is undefined then !!defaultChecked is false.
SiTaggart
reviewed
Feb 2, 2022
TheSisb
reviewed
Feb 2, 2022
nkrantz
approved these changes
Feb 4, 2022
packages/paste-core/components/checkbox/__tests__/checkbox.test.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+111
to
+112
| The checkbox can either be controlled, meaning there is an external state that determines if the checkbox is checked or not, or uncontrolled, meaning the checkbox manages its own state. | ||
|
|
There was a problem hiding this comment.
Super helpful to have this context in the docs, might be worth adding a sentence about why one would want an uncontrolled vs controlled checkbox
| const handleChange = props.onChange != null ? props.onChange : checkboxGroupContext.onChange; | ||
|
|
||
| // Manages what the value of checked is depending on if it is controlled or uncontrolled | ||
| const [checkedState, setCheckedState] = React.useState(!!defaultChecked); |
There was a problem hiding this comment.
because defaultChecked is a boolean, what's the difference between using the double bang operator and just saying useState(defaultChecked)? wouldn't that still give you either true or false?
TheSisb
approved these changes
Feb 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug found in: #2165
Contributing to Twilio