fix: custom plugin to fix esbuild esm imports #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f3116e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 78 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
Status: Do Not Merge
|
✔️ Deploy Preview for paste-theme-designer ready! 🔨 Explore the source changes: f3116e0 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-theme-designer/deploys/62265f38e5fc550007a81d92 😎 Browse the preview: https://deploy-preview-2269--paste-theme-designer.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f3116e0:
|
|
✔️ Deploy Preview for paste-docs ready! 🔨 Explore the source changes: f3116e0 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-docs/deploys/62265f38148ced00077cfcf5 😎 Browse the preview: https://deploy-preview-2269--paste-docs.netlify.app |
|
Size Change: -499 B (0%) Total Size: 508 kB
ℹ️ View Unchanged
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
zahnster
approved these changes
Mar 4, 2022
| const NAME = 'esm-externals'; | ||
| const NAMESPACE = NAME; | ||
|
|
||
| // this is a modified version of https://github.com/remorses/esbuild-plugins/tree/master/esm-externals |
There was a problem hiding this comment.
praise: nice commenting, much appreciated
tools/build/esbuild.js
Outdated
| }, | ||
| }; | ||
| const {EsmExternalsPlugin} = require('./build-plugins/EsmExternals'); | ||
| const {PasteCJSResolverPlugin} = require('./build-plugins/PasteCJSResolver'); |
There was a problem hiding this comment.
praise: nice code organization
shleewhite
approved these changes
Mar 4, 2022
SiTaggart
force-pushed
the
fix/esbuild-imports
branch
from
80ba818
to
53c6a53
Compare
SiTaggart
removed
the
Status: Do Not Merge
|
Praise: Great additions, and look at all those green checks! ✅ |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin we used to fix the esbuild issue with require statements in esm compiled packages reintroduced an issue with incorrectly importing defaults from json files, using
import * as x from 'x'.This is because it blanketly transformed all import statements, even though the bug we were trying to fix was just require statements.
This customized version of the plugin only modifies imports that are require statements and leaves already correct import statements alone.