fix(react-spring-raf): update react-spring deps to resolve raf overload #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f2c2f6d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
zahnster
removed
the
Status: Do Not Merge
SiTaggart
approved these changes
Mar 9, 2022
shleewhite
approved these changes
Mar 9, 2022
|
✔️ Deploy Preview for paste-theme-designer ready! 🔨 Explore the source changes: 7b54348 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-theme-designer/deploys/6228dc820317dd000a3b2a2c 😎 Browse the preview: https://deploy-preview-2282--paste-theme-designer.netlify.app |
|
✔️ Deploy Preview for paste-docs ready! 🔨 Explore the source changes: 7b54348 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-docs/deploys/6228dc82346b9b0008116130 😎 Browse the preview: https://deploy-preview-2282--paste-docs.netlify.app |
|
Size Change: +1.59 kB (0%) Total Size: 518 kB
ℹ️ View Unchanged
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f2c2f6d:
|
I checked out Alert Dialog, Modal, Disclosure, Toast, and the website landing page (which uses our animation library) - all appears to be 👍🏼 |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
zahnster
added
Status: Do Not Merge
|
Is there any blocker to merge this PR? |
|
Hi @askel4dd, yes, none of our tests will pass with this update. It has highlighted a significant memory leak in the test suite. Currently working through those right now before getting back to this. |
SiTaggart
force-pushed
the
fix/react-spring-raf
branch
from
bae25a2
to
4c12a4c
Compare
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
Area: Components
zahnster
force-pushed
the
fix/react-spring-raf
branch
from
2958822
to
1ebd735
Compare
nkrantz
approved these changes
Apr 25, 2022
zahnster
force-pushed
the
fix/react-spring-raf
branch
from
732b934
to
352e7b7
Compare
TheSisb
reviewed
Apr 26, 2022
packages/paste-core/components/skeleton-loader/__tests__/index.spec.tsx
Outdated
Show resolved
Hide resolved
TheSisb
approved these changes
Apr 28, 2022
zahnster
added
🚀 merge it!
and removed
Status: Do Not Merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tested before/after on any component using @twilio-paste/animation-library (such as Alert Dialog, Badge, Toast, etc) I see the unnecessary calls to RAF no longer happening.