feat: add localized fonts to support i18n #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 77b4c3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
shleewhite
commented
Mar 15, 2022
| @@ -1,3 +1,7 @@ | |||
| aliases: | |||
| font-family-10: "'Inter var experimental', 'Inter var', -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Oxygen-Sans, Ubuntu, Cantarell, 'Helvetica Neue', sans-serif" | |||
| font-family-20: "'Fira Mono', 'Courier New', Courier, monospace" | |||
| font-family-ja: "'Inter var experimental', 'Inter var', Hiragino Sans, 'ヒラギノ角ゴ ProN W3', 'Hiragino Kaku Gothic ProN', 'メイリオ', Meiryo, Osaka, 'MS PGothic', sans-serif" | |||
There was a problem hiding this comment.
Question: the other font family aliases use a number, but it felt kind of weird for this case. What should the alias name be?
font-family-ja, font-family-30, or font-family-ja-10?
There was a problem hiding this comment.
General naming convention for alias is that they are number steps. They are generic, buckets of values that have no meaning, and we don't need to think about naming them when adding more.
I'd go with font-family-30 personally
shleewhite
commented
Mar 15, 2022
shleewhite
commented
Mar 15, 2022
shleewhite
commented
Mar 15, 2022
shleewhite
commented
Mar 15, 2022
shleewhite
commented
Mar 15, 2022
| </Button> | ||
| <Input aria-label="Search" placeholder="ダミーテキスト" type="text" /> | ||
| <Select aria-label="Options"> | ||
| <Option value="option1">ダミーテキスト</Option> |
There was a problem hiding this comment.
Note: this says "dummy text"... I read somewhere that Japan doesn't really have lorem ipsum the way we do.
SiTaggart
reviewed
Mar 16, 2022
SiTaggart
reviewed
Mar 16, 2022
github-actions
bot
added
Area: Components
|
✔️ Deploy Preview for paste-theme-designer ready! 🔨 Explore the source changes: 3ddcfc8 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-theme-designer/deploys/6232589757ea86000819c625 😎 Browse the preview: https://deploy-preview-2298--paste-theme-designer.netlify.app |
|
✔️ Deploy Preview for paste-docs ready! 🔨 Explore the source changes: 3ddcfc8 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-docs/deploys/623258978e907700083c1f46 😎 Browse the preview: https://deploy-preview-2298--paste-docs.netlify.app |
|
Size Change: +980 B (0%) Total Size: 510 kB
ℹ️ View Unchanged
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 77b4c3f:
|
|
✅ Deploy Preview for paste-theme-designer ready! 🔨 Explore the source changes: 77b4c3f 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-theme-designer/deploys/6234f276865e7a0009d7e6a5 😎 Browse the preview: https://deploy-preview-2298--paste-theme-designer.netlify.app |
|
✅ Deploy Preview for paste-docs ready! 🔨 Explore the source changes: 77b4c3f 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-docs/deploys/6234f276702de5000826bd13 😎 Browse the preview: https://deploy-preview-2298--paste-docs.netlify.app |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
SiTaggart
reviewed
Mar 17, 2022
shleewhite
added
🚀 merge it!
and removed
Status: Do Not Merge
gloriliale
approved these changes
Mar 18, 2022
Comment on lines
+11
to
+18
| font-family-text-japanese: | ||
| value: "{!font-family-30}" | ||
| font-family-text-korean: | ||
| value: "{!font-family-40}" | ||
| font-family-text-chinese-traditional: | ||
| value: "{!font-family-50}" | ||
| font-family-text-chinese-simplified: | ||
| value: "{!font-family-60}" |
There was a problem hiding this comment.
praise: I really like this approach and think it's going to be useful if we need flexibility in the future. So good!
| </Button> | ||
| <Input aria-label="Search" placeholder="ダミーテキスト" type="text" /> | ||
| <Select aria-label="Options"> | ||
| <Option value="option1">ダミーテキスト</Option> |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
font-family-30,font-family-40,font-family-50,font-family-60font-family-text-japanese,font-family-text-korean,font-family-text-chinese-traditional,font-family-text-chinese-simplifiedclass='paste-theme-provider'tothemeProvider'inherit'(if not monospace)react-helmetas a devDependencyContributing to Twilio