-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create MinimizableDialog component #2623
Conversation
🦋 Changeset detectedLatest commit: 6a71484 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6a71484:
|
Size Change: +259 B (0%) Total Size: 639 kB
ℹ️ View Unchanged
|
08c37da
to
ff37e68
Compare
68d8755
to
b4fc3d5
Compare
packages/paste-core/components/minimizable-dialog/src/MinimizableDialog.tsx
Outdated
Show resolved
Hide resolved
packages/paste-core/components/minimizable-dialog/src/MinimizableDialogHeader.tsx
Show resolved
Hide resolved
packages/paste-core/components/minimizable-dialog/src/MinimizableDialogButton.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Praise: honestly a couple of minor small things, but largely super shippable, so approving in advance of the last couple small things to get upated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is STELLAR!
packages/paste-core/components/minimizable-dialog/src/MinimizableDialogButton.tsx
Show resolved
Hide resolved
packages/paste-website/src/pages/components/minimizable-dialog/index.mdx
Outdated
Show resolved
Hide resolved
packages/paste-website/src/pages/components/minimizable-dialog/index.mdx
Outdated
Show resolved
Hide resolved
packages/paste-website/src/pages/components/minimizable-dialog/index.mdx
Outdated
Show resolved
Hide resolved
packages/paste-website/src/pages/components/minimizable-dialog/index.mdx
Show resolved
Hide resolved
f9a3af3
to
434ad2b
Compare
434ad2b
to
9ad657b
Compare
This PR includes the following changes:
TODO
Contributing to Twilio