chore(utils): remove useMergeRef and add tests for useWindowSize #2719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1aa09d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
nkrantz
force-pushed
the
paste-util-tests
branch
from
59350b9
to
61771ab
Compare
nkrantz
force-pushed
the
paste-util-tests
branch
3 times, most recently
from
8f77830
to
9dca18a
Compare
nkrantz
force-pushed
the
paste-util-tests
branch
2 times, most recently
from
70c7d9b
to
ccf386e
Compare
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
TheSisb
previously approved these changes
Oct 5, 2022
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1aa09d5:
|
|
Size Change: -168 B (0%) Total Size: 749 kB
ℹ️ View Unchanged
|
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ghost
previously approved these changes
Oct 6, 2022
ghost
reviewed
Oct 6, 2022
| @@ -0,0 +1,6 @@ | |||
| --- | |||
| '@twilio-paste/utils': major | |||
| '@twilio-paste/core': minor | |||
There was a problem hiding this comment.
I'm imagining that utils are exposed through the same API from @twilio-paste/core correct? So could do something like this:
import { useMergeRef } from '@twilio-paste/core
If that is true I'm not sure I follow how removing the hook would be a minor change? Perhaps I'm missing some nuance but it all feels like a breaking change and major bump?
There was a problem hiding this comment.
It is indeed exported through core, good callout! Ordinarily this would be a major to core, however I asked Nora to mark it as a minor for two reasons:
- The first and most important is that this is undocumented & internal tooling. Anything that isn't documented is Use At Your Own Risk. It's kind of like pre-v1.0.0 in semver, which means breaking changes don't need to bump the major version.
- Second no one is using this according to our reporting scans. So no need to worry folks for nothing.
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
nkrantz
dismissed stale reviews from ghost
, shleewhite, and TheSisb
via
73f1bb7
nkrantz
force-pushed
the
paste-util-tests
branch
from
ccf386e
to
73f1bb7
Compare
nkrantz
force-pushed
the
paste-util-tests
branch
from
73f1bb7
to
1aa09d5
Compare
TheSisb
approved these changes
Oct 6, 2022
nkrantz
added
🕵🏻♀️ Run website visual regression
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DSYS-3564