Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): export evergreen, twilio and twilio dark themes from index file for consumer reference #3006

Merged
merged 1 commit into from
Feb 2, 2023
Merged

feat(theme): export evergreen, twilio and twilio dark themes from index file for consumer reference #3006

merged 1 commit into from
Feb 2, 2023

Conversation

brandongregoryscott
Copy link
Contributor

@brandongregoryscott brandongregoryscott commented Feb 2, 2023

Hey team,

I updated the Segment app to the latest core version to pull in the Evergreen theme, but it looks like the latest version of @twilio-paste/theme does not export the EvergreenTheme object from its index file for consumer usage. In my use-case, I'd just like to reference a specific token value in a test.

If there's an easier way to do this without hard-coding the value, I'm open to that too! I figure the theme was not intentionally omitted from the index file though - just missed. I noticed the Twilio and Twilio Dark themes are also missing, which I can also add while I'm in here.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@netlify
Copy link

netlify bot commented Feb 2, 2023

‼️ Deploy request for paste-docs rejected.

Name Link
🔨 Latest commit 46cd9f8

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2023

🦋 Changeset detected

Latest commit: 02af835

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@twilio-paste/core Minor
@twilio-paste/theme Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Feb 2, 2023

Deploy Preview for paste-theme-designer ready!

Name Link
🔨 Latest commit 02af835
🔍 Latest deploy log https://app.netlify.com/sites/paste-theme-designer/deploys/63dbd881eb1683000890be6e
😎 Deploy Preview https://deploy-preview-3006--paste-theme-designer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 2, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 02af835:

Sandbox Source
@twilio-paste/nextjs-template Configuration
@twilio-paste/token-contrast-checker Configuration

Copy link
Contributor

@Niznikr Niznikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! 😅 Let's include Twilio and Twilio Dark in there too

@brandongregoryscott brandongregoryscott changed the title fix(theme): export evergreen theme from index file for consumer refererence fix(theme): export evergreen, twilio and twilio dark themes from index file for consumer reference Feb 2, 2023
@brandongregoryscott
Copy link
Contributor Author

Thanks for catching this! 😅 Let's include Twilio and Twilio Dark in there too

Done! I think I've got the messaging/changeset file correct now 😅

Copy link
Contributor

@Niznikr Niznikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brandongregoryscott brandongregoryscott changed the title fix(theme): export evergreen, twilio and twilio dark themes from index file for consumer reference feat(theme): export evergreen, twilio and twilio dark themes from index file for consumer reference Feb 2, 2023
@TheSisb TheSisb merged commit 2bde84f into twilio-labs:main Feb 2, 2023
@TwilioPasteBot TwilioPasteBot mentioned this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants