-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(theme): export evergreen, twilio and twilio dark themes from index file for consumer reference #3006
feat(theme): export evergreen, twilio and twilio dark themes from index file for consumer reference #3006
Conversation
|
Name | Link |
---|---|
🔨 Latest commit | 46cd9f8 |
🦋 Changeset detectedLatest commit: 02af835 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 02af835:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this! 😅 Let's include Twilio and Twilio Dark in there too
…x file for consumer reference
Done! I think I've got the messaging/changeset file correct now 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
Hey team,
I updated the Segment app to the latest core version to pull in the Evergreen theme, but it looks like the latest version of
@twilio-paste/theme
does not export the EvergreenTheme object from its index file for consumer usage. In my use-case, I'd just like to reference a specific token value in a test.If there's an easier way to do this without hard-coding the value, I'm open to that too! I figure the theme was not intentionally omitted from the index file though - just missed. I noticed the Twilio and Twilio Dark themes are also missing, which I can also add while I'm in here.
Contributing to Twilio