feat: Minimizable Dialog updates #3053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5b557c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
the
Area: Components
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Passing run #5495 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5b557c4:
|
|
Size Change: +100 B (0%) Total Size: 897 kB
ℹ️ View Unchanged
|
TheSisb
previously approved these changes
Feb 24, 2023
shleewhite
force-pushed
the
update/minimizable-dialog
branch
from
d78feb4
to
dedae1d
Compare
TheSisb
previously approved these changes
Feb 24, 2023
shleewhite
force-pushed
the
update/minimizable-dialog
branch
from
679daeb
to
2bd550c
Compare
nkrantz
previously approved these changes
Feb 28, 2023
loreina
previously approved these changes
Feb 28, 2023
SiTaggart
reviewed
Feb 28, 2023
| import * as React from 'react'; | ||
| import {Box} from '@twilio-paste/box'; | ||
|
|
||
| export const StyledMinimizableDialog: React.FC<{element?: string; children: React.ReactNode}> = ({ |
There was a problem hiding this comment.
issue(blocker): This needs to be changed for React18. We can no longer do React.FC typings without React.PropsWithChildren
React.FC<React.PropsWithChildren<{element?: string; children: React.ReactNode}>>
There was a problem hiding this comment.
Side note, worries me it doesn't fail type checking
There was a problem hiding this comment.
ooohh is this a react 18 thing?
There was a problem hiding this comment.
Yup Yup. I have updated the VS code snippet too, but I don't know if anyone uses them
shleewhite
force-pushed
the
update/minimizable-dialog
branch
from
2bd550c
to
6a10a07
Compare
shleewhite
added
the
🕵🏻♀️ Run website visual regression
loreina
approved these changes
Mar 1, 2023
SiTaggart
approved these changes
Mar 1, 2023
SiTaggart
added
🚀 merge it!
and removed
Status: Do Not Merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio