New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dangerJS check now correctly detects missing design token changes #3057
Conversation
|
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Passing run #5489 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0bf0001:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Size Change: 0 B Total Size: 897 kB ℹ️ View Unchanged
|
We missed a changeset for a design token change, due to the dangerJS check not correctly identifying design token files
Changes in this PR:
Detect design token files for changesets
We naively only checked for changes in
src
which works for every package except design tokens.This PR makes sure we detect the unique design tokens file structure for changes that need to be published in the dangerJS check
Checklist
required
checks have passed🕵🏻♀️ Run website visual regression
label