fix(data-grid): improve ts typings and react proptypes #3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: 0bab84e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
the
Area: Components
TheSisb
commented
Jun 5, 2023
| @@ -62,9 +62,8 @@ export interface TrProps extends React.TableHTMLAttributes<HTMLTableRowElement> | |||
| children: NonNullable<React.ReactNode>; | |||
| element?: BoxProps['element']; | |||
| verticalAlign?: TableVerticalAlignmentOptions; | |||
| isLastRow?: boolean; | |||
There was a problem hiding this comment.
Wasn't being used, does nothing.
There was a problem hiding this comment.
question: is there a chance it was being used by someone even if it was doing nothing? if so would we want to think twice about removing it to avoid giving someone a new ts error? sidenote: why did we add it in the first place 🤔
TheSisb
commented
Jun 5, 2023
| } | ||
| export interface ThProps extends React.ThHTMLAttributes<HTMLTableHeaderCellElement> { |
There was a problem hiding this comment.
HTMLTableHeaderCellElement was deprecated in favor of HTMLTableCellElement
|
Size Change: +39 B (0%) Total Size: 995 kB
ℹ️ View Unchanged
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0bab84e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
nkrantz
previously approved these changes
Jun 7, 2023
| @@ -62,9 +62,8 @@ export interface TrProps extends React.TableHTMLAttributes<HTMLTableRowElement> | |||
| children: NonNullable<React.ReactNode>; | |||
| element?: BoxProps['element']; | |||
| verticalAlign?: TableVerticalAlignmentOptions; | |||
| isLastRow?: boolean; | |||
There was a problem hiding this comment.
question: is there a chance it was being used by someone even if it was doing nothing? if so would we want to think twice about removing it to avoid giving someone a new ts error? sidenote: why did we add it in the first place 🤔
TheSisb
force-pushed
the
datagrid/fix-types
branch
from
cba3997
to
aa4a3e7
Compare
It's unlikely that people are using it, however even if they are, the error is a good thing. As to why it was added in the first place, probably during development scribbles. |
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0bab84e:
|
Passing run #6059 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
nkrantz
approved these changes
Jun 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves TS typings and proptypes on DataGrid and Table's Tr, Td, and Th elements.
Based on discussions that happened here: #2597