-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve DataGrid colspan props, types and docs #2597
Conversation
🦋 Changeset detectedLatest commit: 417df6d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 417df6d:
|
Size Change: +24 B (0%) Total Size: 595 kB
ℹ️ View Unchanged
|
11a90b0
to
8be61c6
Compare
packages/paste-core/components/data-grid/src/DataGridHeader.tsx
Outdated
Show resolved
Hide resolved
packages/paste-core/components/data-grid/stories/components/ColumnSpanDataGrid.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first PR! 🔥 could you add the colSpan
prop to the props tables on the bottom of the Data Grid docs page?
packages/paste-core/components/data-grid/src/DataGridHeader.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳 WooO! Just had one comment about the tests.
packages/paste-core/components/data-grid/__tests__/index.spec.tsx
Outdated
Show resolved
Hide resolved
packages/paste-core/components/data-grid/src/DataGridHeader.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Praise: super neat and tidy!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!! If you have time to add the colSpan
prop to the Data Grid props table and also another example showing the different column sizes, that'd be great just so that people know it's available to them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
@nkrantz thanks for the reminder about the prop table I'll make sure to add this here before merge! |
Contributing to Twilio