Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve DataGrid colspan props, types and docs #2597

Merged
merged 4 commits into from
Aug 9, 2022
Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 8, 2022

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@ghost ghost self-requested a review as a code owner August 8, 2022 19:29
@ghost ghost requested a review from TheSisb August 8, 2022 19:29
@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2022

🦋 Changeset detected

Latest commit: 417df6d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@twilio-paste/core Patch
@twilio-paste/data-grid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ghost ghost self-assigned this Aug 8, 2022
@github-actions github-actions bot added Status: Do Not Merge This PR is not yet ready to be merged back into the main branch Area: Components Related to the component library (core) of this system Type: Tests Adds tests to the code labels Aug 8, 2022
@netlify
Copy link

netlify bot commented Aug 8, 2022

Deploy Preview for paste-theme-designer ready!

Name Link
🔨 Latest commit 417df6d
🔍 Latest deploy log https://app.netlify.com/sites/paste-theme-designer/deploys/62f2a5f6c6fd060008a54706
😎 Deploy Preview https://deploy-preview-2597--paste-theme-designer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 8, 2022

Deploy Preview for paste-docs ready!

Name Link
🔨 Latest commit 417df6d
🔍 Latest deploy log https://app.netlify.com/sites/paste-docs/deploys/62f2a5f6b1ecd70009d0060f
😎 Deploy Preview https://deploy-preview-2597--paste-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cypress
Copy link

cypress bot commented Aug 8, 2022



Test summary

154 0 0 0Flakiness 1


Run details

Project Paste
Status Passed
Commit 410fd80 ℹ️
Started Aug 9, 2022 6:32 PM
Ended Aug 9, 2022 6:35 PM
Duration 03:19 💡
OS Linux Ubuntu - 20.04
Browser Electron 94

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/filter-group-examples/index.spec.ts Flakiness
1 Custom date/time pattern example > opens the popover when click the button

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 8, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 417df6d:

Sandbox Source
@twilio-paste/nextjs-template Configuration
@twilio-paste/token-contrast-checker Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

Size Change: +24 B (0%)

Total Size: 595 kB

Filename Size Change
packages/paste-core/components/data-grid/dist/index.js 5.05 kB +24 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/paste-icons/cjs/AgentIcon.js 1.4 kB
./packages/paste-icons/cjs/ArrowBackIcon.js 1.15 kB
./packages/paste-icons/cjs/ArrowDownIcon.js 1.15 kB
./packages/paste-icons/cjs/ArrowForwardIcon.js 1.16 kB
./packages/paste-icons/cjs/ArrowUpIcon.js 1.18 kB
./packages/paste-icons/cjs/AttachIcon.js 1.3 kB
./packages/paste-icons/cjs/AttachmentIcon.js 1.22 kB
./packages/paste-icons/cjs/BoldIcon.js 1.37 kB
./packages/paste-icons/cjs/BuiltInIcon.js 1.19 kB
./packages/paste-icons/cjs/CalendarIcon.js 1.25 kB
./packages/paste-icons/cjs/ChatIcon.js 1.28 kB
./packages/paste-icons/cjs/CheckboxCheckIcon.js 1.06 kB
./packages/paste-icons/cjs/CheckboxLineIcon.js 1.01 kB
./packages/paste-icons/cjs/CheckmarkCircleIcon.js 1.14 kB
./packages/paste-icons/cjs/ChevronDisclosureCollapsedIcon.js 1.08 kB
./packages/paste-icons/cjs/ChevronDisclosureExpandedIcon.js 1.08 kB
./packages/paste-icons/cjs/ChevronDisclosureIcon.js 1.08 kB
./packages/paste-icons/cjs/ChevronDoubleLeftIcon.js 1.1 kB
./packages/paste-icons/cjs/ChevronDoubleRightIcon.js 1.13 kB
./packages/paste-icons/cjs/ChevronDownIcon.js 1.05 kB
./packages/paste-icons/cjs/ChevronExpandIcon.js 1.09 kB
./packages/paste-icons/cjs/ChevronLeftIcon.js 1.05 kB
./packages/paste-icons/cjs/ChevronRightIcon.js 1.05 kB
./packages/paste-icons/cjs/ChevronUpIcon.js 1.04 kB
./packages/paste-icons/cjs/CloseCircleIcon.js 1.1 kB
./packages/paste-icons/cjs/CloseIcon.js 1.05 kB
./packages/paste-icons/cjs/ColorPickerIcon.js 1.28 kB
./packages/paste-icons/cjs/ConnectivityAvailableIcon.js 975 B
./packages/paste-icons/cjs/ConnectivityBusyIcon.js 972 B
./packages/paste-icons/cjs/ConnectivityNeutralIcon.js 974 B
./packages/paste-icons/cjs/ConnectivityOfflineIcon.js 1.02 kB
./packages/paste-icons/cjs/ConnectivityUnavailableIcon.js 977 B
./packages/paste-icons/cjs/CopyIcon.js 1.26 kB
./packages/paste-icons/cjs/CreditCardIcon.js 1.08 kB
./packages/paste-icons/cjs/CustomIcon.js 1.35 kB
./packages/paste-icons/cjs/DarkModeIcon.js 1.12 kB
./packages/paste-icons/cjs/DataBarChartIcon.js 1.1 kB
./packages/paste-icons/cjs/DataLineChartIcon.js 1.12 kB
./packages/paste-icons/cjs/DataPieChartIcon.js 1.11 kB
./packages/paste-icons/cjs/DataTableIcon.js 1.1 kB
./packages/paste-icons/cjs/DeleteIcon.js 1.24 kB
./packages/paste-icons/cjs/DownloadIcon.js 1.1 kB
./packages/paste-icons/cjs/EditIcon.js 1.23 kB
./packages/paste-icons/cjs/ElasticSIPTrunkingCapableIcon.js 1.53 kB
./packages/paste-icons/cjs/ErrorIcon.js 1.13 kB
./packages/paste-icons/cjs/ExpandIcon.js 1.22 kB
./packages/paste-icons/cjs/ExportIcon.js 1.09 kB
./packages/paste-icons/cjs/FaxCapableIcon.js 1.4 kB
./packages/paste-icons/cjs/FileIcon.js 1.1 kB
./packages/paste-icons/cjs/FilterIcon.js 1 kB
./packages/paste-icons/cjs/helpers/IconWrapper.js 1.1 kB
./packages/paste-icons/cjs/HideIcon.js 1.46 kB
./packages/paste-icons/cjs/HistoryIcon.js 1.16 kB
./packages/paste-icons/cjs/InformationIcon.js 1.05 kB
./packages/paste-icons/cjs/ItalicIcon.js 1.1 kB
./packages/paste-icons/cjs/LightModeIcon.js 1.23 kB
./packages/paste-icons/cjs/LinkExternalIcon.js 1.15 kB
./packages/paste-icons/cjs/LinkIcon.js 1.3 kB
./packages/paste-icons/cjs/LoadingIcon.js 1.36 kB
./packages/paste-icons/cjs/LogoTwilioIcon.js 1.11 kB
./packages/paste-icons/cjs/LowerHandIcon.js 1.58 kB
./packages/paste-icons/cjs/MicrophoneOffIcon.js 1.37 kB
./packages/paste-icons/cjs/MicrophoneOnIcon.js 1.2 kB
./packages/paste-icons/cjs/MinusIcon.js 1.05 kB
./packages/paste-icons/cjs/MMSCapableIcon.js 1.34 kB
./packages/paste-icons/cjs/MoreIcon.js 1.02 kB
./packages/paste-icons/cjs/NeutralIcon.js 1.27 kB
./packages/paste-icons/cjs/NewIcon.js 1.36 kB
./packages/paste-icons/cjs/OrderedListIcon.js 1.32 kB
./packages/paste-icons/cjs/PauseIcon.js 1.08 kB
./packages/paste-icons/cjs/PinIcon.js 1.28 kB
./packages/paste-icons/cjs/PlayIcon.js 1.1 kB
./packages/paste-icons/cjs/PlusIcon.js 1.02 kB
./packages/paste-icons/cjs/ProcessDisabledIcon.js 1.05 kB
./packages/paste-icons/cjs/ProcessDraftIcon.js 1.32 kB
./packages/paste-icons/cjs/ProcessErrorIcon.js 1.04 kB
./packages/paste-icons/cjs/ProcessInProgressIcon.js 1.06 kB
./packages/paste-icons/cjs/ProcessNeutralIcon.js 1.06 kB
./packages/paste-icons/cjs/ProcessSuccessIcon.js 971 B
./packages/paste-icons/cjs/ProcessWarningIcon.js 1.08 kB
./packages/paste-icons/cjs/ProductAddOnsIcon.js 1.45 kB
./packages/paste-icons/cjs/ProductAdminAccessControlIcon.js 1.68 kB
./packages/paste-icons/cjs/ProductAdminAccountsIcon.js 1.19 kB
./packages/paste-icons/cjs/ProductAdminDomainsIcon.js 1.92 kB
./packages/paste-icons/cjs/ProductAdminResoldCustomersIcon.js 1.48 kB
./packages/paste-icons/cjs/ProductAdminSSOIcon.js 1.67 kB
./packages/paste-icons/cjs/ProductAdminUsersIcon.js 1.56 kB
./packages/paste-icons/cjs/ProductAlarmsIcon.js 1.38 kB
./packages/paste-icons/cjs/ProductAPIExplorerIcon.js 1.34 kB
./packages/paste-icons/cjs/ProductAssetsIcon.js 1.15 kB
./packages/paste-icons/cjs/ProductAuthyIcon.js 1.29 kB
./packages/paste-icons/cjs/ProductAutopilotIcon.js 1.5 kB
./packages/paste-icons/cjs/ProductBillingIcon.js 1.4 kB
./packages/paste-icons/cjs/ProductChannelsIcon.js 1.13 kB
./packages/paste-icons/cjs/ProductChatIcon.js 1.23 kB
./packages/paste-icons/cjs/ProductCLIIcon.js 1.17 kB
./packages/paste-icons/cjs/ProductCodeExchangeCommunityIcon.js 1.82 kB
./packages/paste-icons/cjs/ProductCodeExchangePartnerIcon.js 1.74 kB
./packages/paste-icons/cjs/ProductConnectedDevicesIcon.js 1.6 kB
./packages/paste-icons/cjs/ProductConversationsIcon.js 1.3 kB
./packages/paste-icons/cjs/ProductDebuggerIcon.js 1.52 kB
./packages/paste-icons/cjs/ProductElasticSIPTrunkingIcon.js 1.54 kB
./packages/paste-icons/cjs/ProductEmailAPIIcon.js 1.16 kB
./packages/paste-icons/cjs/ProductEngagementIntelligencePlatformIcon.js 1.34 kB
./packages/paste-icons/cjs/ProductEventStreamsIcon.js 1.4 kB
./packages/paste-icons/cjs/ProductFaxIcon.js 1.42 kB
./packages/paste-icons/cjs/ProductFlexIcon.js 1.17 kB
./packages/paste-icons/cjs/ProductFrontlineIcon.js 1.16 kB
./packages/paste-icons/cjs/ProductFunctionsIcon.js 1.29 kB
./packages/paste-icons/cjs/ProductHomeIcon.js 1.16 kB
./packages/paste-icons/cjs/ProductInsightsIcon.js 1.44 kB
./packages/paste-icons/cjs/ProductInterconnectIcon.js 1.17 kB
./packages/paste-icons/cjs/ProductInternetOfThingsEmbeddedSIMIcon.js 1.21 kB
./packages/paste-icons/cjs/ProductInternetOfThingsIcon.js 1.22 kB
./packages/paste-icons/cjs/ProductInternetOfThingsNarrowbandIcon.js 1.36 kB
./packages/paste-icons/cjs/ProductInternetOfThingsSuperSIMIcon.js 1.4 kB
./packages/paste-icons/cjs/ProductInternetOfThingsTrustOnboardIcon.js 1.43 kB
./packages/paste-icons/cjs/ProductInternetOfThingsWirelessIcon.js 1.32 kB
./packages/paste-icons/cjs/ProductKeysIcon.js 1.51 kB
./packages/paste-icons/cjs/ProductLiveIcon.js 1.32 kB
./packages/paste-icons/cjs/ProductLogsIcon.js 1.35 kB
./packages/paste-icons/cjs/ProductLookupIcon.js 1.09 kB
./packages/paste-icons/cjs/ProductMarketingCampaignsIcon.js 1.22 kB
./packages/paste-icons/cjs/ProductMessagingIcon.js 1.19 kB
./packages/paste-icons/cjs/ProductMicrovisorIcon.js 1.36 kB
./packages/paste-icons/cjs/ProductNotifyIcon.js 1.3 kB
./packages/paste-icons/cjs/ProductPhoneNumbersIcon.js 1.3 kB
./packages/paste-icons/cjs/ProductProxyIcon.js 1.36 kB
./packages/paste-icons/cjs/ProductRegionalIcon.js 1.89 kB
./packages/paste-icons/cjs/ProductSDKIcon.js 1.26 kB
./packages/paste-icons/cjs/ProductSegmentIcon.js 1.31 kB
./packages/paste-icons/cjs/ProductSettingsIcon.js 1.65 kB
./packages/paste-icons/cjs/ProductStudioIcon.js 1.1 kB
./packages/paste-icons/cjs/ProductSupportIcon.js 1.18 kB
./packages/paste-icons/cjs/ProductSyncIcon.js 1.33 kB
./packages/paste-icons/cjs/ProductTaskRouterIcon.js 1.15 kB
./packages/paste-icons/cjs/ProductTrustHubIcon.js 1.38 kB
./packages/paste-icons/cjs/ProductTwilioOrgIcon.js 1.37 kB
./packages/paste-icons/cjs/ProductTwiMLBinsIcon.js 1.09 kB
./packages/paste-icons/cjs/ProductUsageIcon.js 1.54 kB
./packages/paste-icons/cjs/ProductVerifyIcon.js 1.28 kB
./packages/paste-icons/cjs/ProductVideoIcon.js 1.2 kB
./packages/paste-icons/cjs/ProductVoiceIcon.js 1.4 kB
./packages/paste-icons/cjs/RaiseHandIcon.js 2.29 kB
./packages/paste-icons/cjs/ScreenShareIcon.js 1.14 kB
./packages/paste-icons/cjs/SearchIcon.js 1.06 kB
./packages/paste-icons/cjs/SendIcon.js 1.21 kB
./packages/paste-icons/cjs/ShowIcon.js 1.33 kB
./packages/paste-icons/cjs/ShrinkIcon.js 1.26 kB
./packages/paste-icons/cjs/SkipBackIcon.js 1.17 kB
./packages/paste-icons/cjs/SkipForwardIcon.js 1.17 kB
./packages/paste-icons/cjs/SMSCapableIcon.js 1.12 kB
./packages/paste-icons/cjs/StopScreenShareIcon.js 1.13 kB
./packages/paste-icons/cjs/StrikethroughIcon.js 1.29 kB
./packages/paste-icons/cjs/SuccessIcon.js 1.08 kB
./packages/paste-icons/cjs/SupportIcon.js 1.19 kB
./packages/paste-icons/cjs/TextFormatIcon.js 1.16 kB
./packages/paste-icons/cjs/ThemeIcon.js 1.45 kB
./packages/paste-icons/cjs/ThumbsDownIcon.js 1.76 kB
./packages/paste-icons/cjs/ThumbsUpIcon.js 1.75 kB
./packages/paste-icons/cjs/UnderlineIcon.js 1.14 kB
./packages/paste-icons/cjs/UnorderedListIcon.js 1.1 kB
./packages/paste-icons/cjs/UnpinIcon.js 1.16 kB
./packages/paste-icons/cjs/UnsortedIcon.js 1.17 kB
./packages/paste-icons/cjs/UploadToCloudIcon.js 1.53 kB
./packages/paste-icons/cjs/UserIcon.js 1.07 kB
./packages/paste-icons/cjs/VideoOffIcon.js 1.28 kB
./packages/paste-icons/cjs/VideoOnIcon.js 1.22 kB
./packages/paste-icons/cjs/VoiceCapableIcon.js 1.32 kB
./packages/paste-icons/cjs/VolumeOffIcon.js 1.33 kB
./packages/paste-icons/cjs/VolumeOnIcon.js 1.44 kB
./packages/paste-icons/cjs/WarningIcon.js 1.19 kB
packages/paste-color-contrast-utils/dist/index.js 15.3 kB
packages/paste-core/components/alert-dialog/dist/index.js 2.08 kB
packages/paste-core/components/alert/dist/index.js 2.1 kB
packages/paste-core/components/anchor/dist/index.js 1.86 kB
packages/paste-core/components/avatar/dist/index.js 3.34 kB
packages/paste-core/components/badge/dist/index.js 2.29 kB
packages/paste-core/components/base-radio-checkbox/dist/index.js 1.64 kB
packages/paste-core/components/breadcrumb/dist/index.js 1.58 kB
packages/paste-core/components/button/dist/index.js 5.86 kB
packages/paste-core/components/card/dist/index.js 1.13 kB
packages/paste-core/components/chat-log/dist/index.js 7.66 kB
packages/paste-core/components/checkbox/dist/index.js 2.92 kB
packages/paste-core/components/combobox/dist/index.js 16.8 kB
packages/paste-core/components/date-picker/dist/index.js 8.06 kB
packages/paste-core/components/disclosure/dist/index.js 2.59 kB
packages/paste-core/components/display-pill-group/dist/index.js 1.3 kB
packages/paste-core/components/form-pill-group/dist/index.js 2.7 kB
packages/paste-core/components/heading/dist/index.js 1.3 kB
packages/paste-core/components/help-text/dist/index.js 1.3 kB
packages/paste-core/components/inline-control-group/dist/index.js 1.43 kB
packages/paste-core/components/input-box/dist/index.js 2.23 kB
packages/paste-core/components/input/dist/index.js 1.84 kB
packages/paste-core/components/label/dist/index.js 1.64 kB
packages/paste-core/components/list/dist/index.js 1.35 kB
packages/paste-core/components/menu/dist/index.js 2.36 kB
packages/paste-core/components/modal/dist/index.js 3.35 kB
packages/paste-core/components/pagination/dist/index.js 3.44 kB
packages/paste-core/components/paragraph/dist/index.js 1.05 kB
packages/paste-core/components/popover/dist/index.js 2.36 kB
packages/paste-core/components/radio-group/dist/index.js 2.26 kB
packages/paste-core/components/screen-reader-only/dist/index.js 1.06 kB
packages/paste-core/components/select/dist/index.js 1.96 kB
packages/paste-core/components/separator/dist/index.js 1.18 kB
packages/paste-core/components/skeleton-loader/dist/index.js 1.47 kB
packages/paste-core/components/spinner/dist/index.js 1.65 kB
packages/paste-core/components/table/dist/index.js 2.23 kB
packages/paste-core/components/tabs/dist/index.js 2.57 kB
packages/paste-core/components/textarea/dist/index.js 1.61 kB
packages/paste-core/components/time-picker/dist/index.js 8.08 kB
packages/paste-core/components/toast/dist/index.js 3.67 kB
packages/paste-core/components/tooltip/dist/index.js 1.56 kB
packages/paste-core/components/truncate/dist/index.js 1.04 kB
packages/paste-core/core-bundle/dist/alert-dialog.js 229 B
packages/paste-core/core-bundle/dist/alert.js 219 B
packages/paste-core/core-bundle/dist/anchor.js 220 B
packages/paste-core/core-bundle/dist/animation-library.js 232 B
packages/paste-core/core-bundle/dist/aspect-ratio.js 228 B
packages/paste-core/core-bundle/dist/avatar.js 220 B
packages/paste-core/core-bundle/dist/badge.js 220 B
packages/paste-core/core-bundle/dist/base-radio-checkbox.js 236 B
packages/paste-core/core-bundle/dist/box.js 218 B
packages/paste-core/core-bundle/dist/breadcrumb.js 224 B
packages/paste-core/core-bundle/dist/button.js 220 B
packages/paste-core/core-bundle/dist/card.js 219 B
packages/paste-core/core-bundle/dist/chat-log.js 225 B
packages/paste-core/core-bundle/dist/checkbox.js 223 B
packages/paste-core/core-bundle/dist/clipboard-copy-library.js 241 B
packages/paste-core/core-bundle/dist/color-contrast-utils.js 239 B
packages/paste-core/core-bundle/dist/combobox-primitive.js 234 B
packages/paste-core/core-bundle/dist/combobox.js 222 B
packages/paste-core/core-bundle/dist/customization.js 225 B
packages/paste-core/core-bundle/dist/data-grid.js 226 B
packages/paste-core/core-bundle/dist/data-visualization-library.js 243 B
packages/paste-core/core-bundle/dist/date-picker.js 227 B
packages/paste-core/core-bundle/dist/design-tokens.js 230 B
packages/paste-core/core-bundle/dist/disclosure-primitive.js 234 B
packages/paste-core/core-bundle/dist/disclosure.js 223 B
packages/paste-core/core-bundle/dist/display-pill-group.js 236 B
packages/paste-core/core-bundle/dist/dropdown-library.js 232 B
packages/paste-core/core-bundle/dist/flex.js 219 B
packages/paste-core/core-bundle/dist/form-pill-group.js 234 B
packages/paste-core/core-bundle/dist/grid.js 220 B
packages/paste-core/core-bundle/dist/heading.js 221 B
packages/paste-core/core-bundle/dist/help-text.js 226 B
packages/paste-core/core-bundle/dist/index.js 1.47 kB
packages/paste-core/core-bundle/dist/inline-control-group.js 238 B
packages/paste-core/core-bundle/dist/input-box.js 226 B
packages/paste-core/core-bundle/dist/input.js 219 B
packages/paste-core/core-bundle/dist/label.js 220 B
packages/paste-core/core-bundle/dist/list.js 219 B
packages/paste-core/core-bundle/dist/media-object.js 226 B
packages/paste-core/core-bundle/dist/menu-primitive.js 230 B
packages/paste-core/core-bundle/dist/menu.js 219 B
packages/paste-core/core-bundle/dist/modal-dialog-primitive.js 241 B
packages/paste-core/core-bundle/dist/modal.js 220 B
packages/paste-core/core-bundle/dist/non-modal-dialog-primitive.js 244 B
packages/paste-core/core-bundle/dist/pagination.js 224 B
packages/paste-core/core-bundle/dist/paragraph.js 224 B
packages/paste-core/core-bundle/dist/popover.js 220 B
packages/paste-core/core-bundle/dist/radio-group.js 228 B
packages/paste-core/core-bundle/dist/react-textarea-autosize-library.js 248 B
packages/paste-core/core-bundle/dist/reakit-library.js 229 B
packages/paste-core/core-bundle/dist/screen-reader-only.js 235 B
packages/paste-core/core-bundle/dist/select.js 218 B
packages/paste-core/core-bundle/dist/separator.js 223 B
packages/paste-core/core-bundle/dist/sibling-box.js 228 B
packages/paste-core/core-bundle/dist/skeleton-loader.js 230 B
packages/paste-core/core-bundle/dist/spinner.js 221 B
packages/paste-core/core-bundle/dist/stack.js 220 B
packages/paste-core/core-bundle/dist/style-props.js 226 B
packages/paste-core/core-bundle/dist/styling-library.js 230 B
packages/paste-core/core-bundle/dist/table.js 218 B
packages/paste-core/core-bundle/dist/tabs-primitive.js 230 B
packages/paste-core/core-bundle/dist/tabs.js 219 B
packages/paste-core/core-bundle/dist/text.js 219 B
packages/paste-core/core-bundle/dist/textarea.js 221 B
packages/paste-core/core-bundle/dist/theme.js 220 B
packages/paste-core/core-bundle/dist/time-picker.js 228 B
packages/paste-core/core-bundle/dist/toast.js 218 B
packages/paste-core/core-bundle/dist/tooltip-primitive.js 231 B
packages/paste-core/core-bundle/dist/tooltip.js 221 B
packages/paste-core/core-bundle/dist/truncate.js 221 B
packages/paste-core/core-bundle/dist/types.js 220 B
packages/paste-core/core-bundle/dist/uid-library.js 227 B
packages/paste-core/core-bundle/dist/utils.js 219 B
packages/paste-core/layout/aspect-ratio/dist/index.js 1.05 kB
packages/paste-core/layout/flex/dist/index.js 2.33 kB
packages/paste-core/layout/grid/dist/index.js 2.26 kB
packages/paste-core/layout/media-object/dist/index.js 1.34 kB
packages/paste-core/layout/stack/dist/index.js 1.52 kB
packages/paste-core/primitives/box/dist/index.js 3.37 kB
packages/paste-core/primitives/combobox/dist/index.js 583 B
packages/paste-core/primitives/disclosure/dist/index.js 479 B
packages/paste-core/primitives/menu/dist/index.js 546 B
packages/paste-core/primitives/modal-dialog/dist/index.js 23.9 kB
packages/paste-core/primitives/non-modal-dialog/dist/index.js 502 B
packages/paste-core/primitives/sibling-box/dist/index.js 1.5 kB
packages/paste-core/primitives/tabs/dist/index.js 482 B
packages/paste-core/primitives/text/dist/index.js 2.94 kB
packages/paste-core/primitives/tooltip/dist/index.js 489 B
packages/paste-customization/dist/index.js 2.27 kB
packages/paste-design-tokens/dist/themes/dark/tokens.common.js 4.12 kB
packages/paste-design-tokens/dist/themes/dark/tokens.generic.js 5.75 kB
packages/paste-design-tokens/dist/themes/sendgrid/tokens.common.js 4.1 kB
packages/paste-design-tokens/dist/themes/sendgrid/tokens.generic.js 6.26 kB
packages/paste-design-tokens/dist/tokens.common.js 4.74 kB
packages/paste-design-tokens/dist/tokens.generic.js 6.32 kB
packages/paste-libraries/animation/dist/index.js 23.2 kB
packages/paste-libraries/clipboard-copy/dist/index.js 1.58 kB
packages/paste-libraries/data-visualization/dist/index.js 2.08 kB
packages/paste-libraries/dropdown/dist/index.js 23.5 kB
packages/paste-libraries/react-textarea-autosize/dist/index.js 8.22 kB
packages/paste-libraries/reakit/dist/index.js 42.2 kB
packages/paste-libraries/styling/dist/index.js 27.3 kB
packages/paste-libraries/uid/dist/index.js 4.61 kB
packages/paste-style-props/dist/index.js 6.35 kB
packages/paste-theme/dist/index.js 3.65 kB
packages/paste-types/dist/index.js 328 B
packages/paste-utils/dist/index.js 2.79 kB

compressed-size-action

@ghost ghost force-pushed the jb-DSYS-3136 branch 2 times, most recently from 11a90b0 to 8be61c6 Compare August 8, 2022 19:55
Copy link
Collaborator

@nkrantz nkrantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first PR! 🔥 could you add the colSpan prop to the props tables on the bottom of the Data Grid docs page?

.changeset/dull-singers-decide.md Outdated Show resolved Hide resolved
Copy link
Contributor

@shleewhite shleewhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 WooO! Just had one comment about the tests.

Copy link
Contributor

@SiTaggart SiTaggart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praise: super neat and tidy!

Copy link
Collaborator

@nkrantz nkrantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!! If you have time to add the colSpan prop to the Data Grid props table and also another example showing the different column sizes, that'd be great just so that people know it's available to them.

Copy link
Contributor

@shleewhite shleewhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@ghost
Copy link
Author

ghost commented Aug 9, 2022

@nkrantz thanks for the reminder about the prop table I'll make sure to add this here before merge!

@ghost ghost self-requested a review as a code owner August 9, 2022 17:07
@ghost ghost requested a review from sandsng August 9, 2022 17:07
@github-actions github-actions bot added Area: Doc Site Related to the documentation website Type: Documentation Improvements or additions to documentation labels Aug 9, 2022
@TheSisb TheSisb enabled auto-merge (squash) August 9, 2022 18:23
@TheSisb TheSisb disabled auto-merge August 9, 2022 19:38
@TheSisb TheSisb merged commit e21a9ff into main Aug 9, 2022
@TheSisb TheSisb deleted the jb-DSYS-3136 branch August 9, 2022 19:38
@TwilioPasteBot TwilioPasteBot mentioned this pull request Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Components Related to the component library (core) of this system Area: Doc Site Related to the documentation website Status: Do Not Merge This PR is not yet ready to be merged back into the main branch Type: Documentation Improvements or additions to documentation Type: Tests Adds tests to the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants