feat(chat-log): add clear function and improve animations #3271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: 8c52942 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
Area: Components
TheSisb
force-pushed
the
chat-log/add-clear-to-hook
branch
from
d5b9a21
to
70d4ff3
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8c52942. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
the
Type: Documentation
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8c52942:
|
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Size Change: +16 B (0%) Total Size: 995 kB
ℹ️ View Unchanged
|
Passing run #6083 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
nkrantz
previously approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Nice addition! Unrelated to your changes here, but I think the pop animation could also use some improvement. The selected message leaves the screen smoothly, but the lower messages jump up kind of roughly to fill the empty space. Not blocking this PR though!
serifluous
previously approved these changes
Jun 9, 2023
|
Any updates on this PR? Did it got stuck? |
nkrantz
added
🕵🏻♀️ Run website visual regression
|
@TerazoBatcaveUser it'll likely merge today, it only got approvals on Friday afternoon and CI was still running which is why it didn't merge before the weekend. |
|
Thanks a lot for the heads up! I have the very same mantra, do not push on Friday. Thanks for the news and heads up! |
SiTaggart
previously approved these changes
Jun 12, 2023
TheSisb
dismissed stale reviews from SiTaggart, nkrantz, and serifluous
via
8c52942
TheSisb
force-pushed
the
chat-log/add-clear-to-hook
branch
from
6cfe15f
to
8c52942
Compare
nkrantz
approved these changes
Jun 13, 2023
Merged
|
Hi team! good morning! I got notified that this was merged, tested, and working so far, is there any possible ETA to see the new version on NPM? I know it has been only 40 mins but I would love to use the new features :] https://www.npmjs.com/package/@twilio-paste/core |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3266
Also I adjust the animations to enter/leave more smoothly.