docs: create visual picker docs #3370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: 2cd63ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
Type: Documentation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2cd63ec. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
Size Change: +76 B (0%) Total Size: 1.02 MB
ℹ️ View Unchanged
|
serifluous
reviewed
Aug 3, 2023
packages/paste-website/src/pages/components/visual-picker/index.mdx
Outdated
Show resolved
Hide resolved
nkrantz
force-pushed
the
visual-picker-docs
branch
from
98aa375
to
7f1eba7
Compare
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2cd63ec:
|
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1 flaky tests on run #6504 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Full Site VRT Batch 2 > should vrt /components/editable-code-block/ |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
nkrantz
force-pushed
the
visual-picker-docs
branch
from
3dd59c7
to
d475d3e
Compare
github-actions
bot
removed
Area: Infrastructure
TheSisb
reviewed
Aug 4, 2023
packages/paste-website/src/pages/components/visual-picker/index.mdx
Outdated
Show resolved
Hide resolved
packages/paste-website/src/pages/components/visual-picker/index.mdx
Outdated
Show resolved
Hide resolved
serifluous
reviewed
Aug 4, 2023
packages/paste-website/src/pages/components/visual-picker/index.mdx
Outdated
Show resolved
Hide resolved
serifluous
reviewed
Aug 4, 2023
packages/paste-website/src/pages/components/visual-picker/index.mdx
Outdated
Show resolved
Hide resolved
nkrantz
force-pushed
the
visual-picker-docs
branch
from
f2132c9
to
e02f700
Compare
serifluous
reviewed
Aug 9, 2023
packages/paste-website/src/component-examples/VisualPickerExamples.ts
Outdated
Show resolved
Hide resolved
serifluous
reviewed
Aug 9, 2023
packages/paste-website/src/component-examples/VisualPickerExamples.ts
Outdated
Show resolved
Hide resolved
serifluous
previously approved these changes
Aug 9, 2023
SiTaggart
reviewed
Aug 9, 2023
| : null | ||
| marginRight={orientation === 'horizontal' && !isVisualPicker ? 'space70' : null} | ||
| marginLeft={ | ||
| isVisualPicker && orientation === 'horizontal' ? (index === 0 ? 'space0' : 'space30') : 'space0' // Sets spacing between horizontal Visual Pickers except for the first one |
There was a problem hiding this comment.
praise: you're right, I do dislike this, but the comments here, as to why its here, helps us reason about this and ultimately we might find time to refactor this out to a better primitive in the future.
SiTaggart
previously approved these changes
Aug 9, 2023
TheSisb
reviewed
Aug 9, 2023
| ...props | ||
| }, | ||
| ref | ||
| ) => { | ||
| const isVisualPicker = Boolean(fieldStyleProps); // This prop is only used in Visual Picker |
There was a problem hiding this comment.
suggestion: prefer an existence check like fieldStyleProps != null instead of a type coercion
TheSisb
approved these changes
Aug 9, 2023
SiTaggart
added
🚀 merge it!
🕵🏻♀️ Run website visual regression
serifluous
approved these changes
Aug 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.