Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: danger js check for codemods and no changesets #3461

Merged
merged 2 commits into from
Sep 1, 2023
Merged

fix: danger js check for codemods and no changesets #3461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4b5c10
fix: danger js check for codemods and no changesets
SiTaggart Aug 31, 2023
35131d0
Merge branch 'main' into fix/codemods-danger-check
SiTaggart Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/late-forks-vanish.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@twilio-paste/codemods': patch
'@twilio-paste/core': patch
---

[Codemods] Include new ProgressBar Exports
11 changes: 9 additions & 2 deletions .danger/__tests__/utils.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,14 +233,15 @@ describe('danger utils', () => {
).toEqual(['@twilio-paste/style-props', '@twilio-paste/alert-dialog']);
});

it('should return the design-tokens package with even though no src files are updated', () => {
it('should return the design-tokens and codemods package with even though no src files are updated', () => {
expect(
getUnpublishedPackageNames(
[
'package.json',
'packages/paste-style-props/src/index.ts',
'packages/paste-core/components/alert-dialog/stories/index.stories.tsx',
'packages/paste-design-tokens/tokens/themes/evergreen/global/background-color.yml',
'packages/paste-codemods/tools/.cache/mappings.json',
'yarn.lock',
'.changeset/pretty-cameras-burn.md',
],
Expand All @@ -263,9 +264,15 @@ describe('danger utils', () => {
private: false,
location: '/Users/simon/dev/twilio/design-systems/paste/packages/paste-design-tokens',
},
{
name: '@twilio-paste/codemods',
version: '3.1.0',
private: false,
location: '/Users/simon/dev/twilio/design-systems/paste/packages/paste-codemods',
},
]
)
).toEqual(['@twilio-paste/style-props', '@twilio-paste/design-tokens']);
).toEqual(['@twilio-paste/style-props', '@twilio-paste/design-tokens', '@twilio-paste/codemods']);
});
});

Expand Down
3 changes: 2 additions & 1 deletion .danger/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ export const getUnpublishedPackageNames = (touchedFiles: string[], publicPackage
filePath.includes('/src/') ||
filePath.includes('/paste-design-tokens/tokens/') ||
filePath.includes('/paste-design-tokens/formatters/') ||
filePath.includes('/paste-design-tokens/types/')
filePath.includes('/paste-design-tokens/types/') ||
filePath.includes('/paste-codemods/')
) {
uniquePackages.add(packageName);
}
Expand Down
Loading