feat: component type docs (a-c) #3505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: be2d11d The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
nkrantz
changed the title
github-actions
bot
added
Area: Components
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit be2d11d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit be2d11d:
|
Passing run #6913 ↗︎
Details:
Review all test suite changes for PR #3505 ↗︎ |
|||||||||||||||
|
Size Change: -44 B (0%) Total Size: 1 MB
ℹ️ View Unchanged
|
nkrantz
force-pushed
the
type-docs-a-c
branch
from
ef8bd4c
to
dc24e0d
Compare
github-actions
bot
added
Type: Documentation
nkrantz
force-pushed
the
type-docs-a-c
branch
from
dc24e0d
to
d767353
Compare
nkrantz
changed the title
nkrantz
force-pushed
the
type-docs-a-c
branch
from
d767353
to
0aee70f
Compare
nkrantz
force-pushed
the
type-docs-a-c
branch
2 times, most recently
from
424753a
to
380be58
Compare
TheSisb
reviewed
Sep 29, 2023
packages/paste-website/src/components/site-wrapper/sidebar/SidebarNavigation.tsx
Show resolved
Hide resolved
serifluous
reviewed
Sep 29, 2023
packages/paste-website/src/pages/components/account-switcher/api.mdx
Outdated
Show resolved
Hide resolved
serifluous
reviewed
Sep 29, 2023
serifluous
reviewed
Sep 29, 2023
There was a problem hiding this comment.
issue: A whole bunch of inherited props on AccountSwitcher, AccountSwitcherItem, AccountSwitcherRadio, AccountSwitcherBadge show up as required. Not sure if they all actually are and the value also gets inherited from somewhere else, but it's mainly just kinda unexpected to see required props hidden away.
github-actions
bot
added
the
Area: Infrastructure
github-actions
bot
removed
Area: Theme
github-actions
bot
added
Area: Infrastructure
TheSisb
previously approved these changes
Oct 2, 2023
TheSisb
reviewed
Oct 2, 2023
Comment on lines
+2
to
+3
| '@twilio-paste/code-block': patch | ||
| '@twilio-paste/core': patch |
There was a problem hiding this comment.
You can merge a lot of these changesets into a single one, with the same message:
ie:
---
'@twilio-paste/code-block': patch
'@twilio-paste/chat-log': patch
'@twilio-paste/core': patch
---
Improved TsDoc type annotations
The benefit is, I suspect, it wont bump core 10+ times
There was a problem hiding this comment.
It'll only bump it once, it rolls core up into a single minor or patch. The advantage here is that you get a package level dedicated changelog entry. So you're not sharing a single changelog entry for multiple packages, making the package changelog much more isolated and specific to that package only.
SiTaggart
reviewed
Oct 3, 2023
packages/paste-core/components/button-group/src/ButtonGroup.tsx
Outdated
Show resolved
Hide resolved
SiTaggart
reviewed
Oct 3, 2023
SiTaggart
reviewed
Oct 3, 2023
SiTaggart
reviewed
Oct 3, 2023
TheSisb
previously approved these changes
Oct 3, 2023
SiTaggart
reviewed
Oct 3, 2023
| * @memberof AvatarProps | ||
| */ | ||
| element?: BoxProps["element"]; | ||
| }; | ||
|
|
||
| export type AvatarContentProps = { |
There was a problem hiding this comment.
I don't think this one is an exported component, but it is appearing on the docsite
There was a problem hiding this comment.
I exported it because we use it in the user-dialog package but yeah it's not ideal on the docs site
SiTaggart
reviewed
Oct 3, 2023
nkrantz
added
🚀 merge it!
🕵🏻♀️ Run website visual regression
TheSisb
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Components A-C