-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: component type docs (a-c) #3505
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@twilio-paste/alert-dialog': patch | ||
'@twilio-paste/core': patch | ||
--- | ||
|
||
[Alert Dialog] Improved TsDoc annotations |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@twilio-paste/breadcrumb': patch | ||
'@twilio-paste/core': patch | ||
--- | ||
|
||
[Breadcrumb] Improved TsDoc type annotations |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@twilio-paste/card': patch | ||
'@twilio-paste/core': patch | ||
--- | ||
|
||
[Card] Improved TsDoc type annotations |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@twilio-paste/chat-composer': patch | ||
'@twilio-paste/core': patch | ||
--- | ||
|
||
[Chat Composer] Improved TsDoc type annotations |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@twilio-paste/combobox': patch | ||
'@twilio-paste/core': patch | ||
--- | ||
|
||
[Combobox] Improved TsDoc type annotations |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@twilio-paste/base-radio-checkbox': patch | ||
'@twilio-paste/core': patch | ||
--- | ||
|
||
[Base-radio-checkbox] Specify exports for clarity in index.js file |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
"@twilio-paste/core": minor | ||
"@twilio-paste/reakit-library": minor | ||
--- | ||
|
||
[Reakit library] export menu state return and menu initial state |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@twilio-paste/alert': patch | ||
'@twilio-paste/core': patch | ||
--- | ||
|
||
[Alert] Improved TsDoc annotations |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@twilio-paste/codemods': patch | ||
--- | ||
|
||
Updated exports for tsdoc additions |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
"@twilio-paste/core": minor | ||
"@twilio-paste/menu-primitive": minor | ||
--- | ||
|
||
[Menu Primitive] new exports for use in the Account Switcher package: MenuPrimitiveInitialState and MenuPrimitiveStateReturn |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@twilio-paste/checkbox': patch | ||
'@twilio-paste/core': patch | ||
--- | ||
|
||
[Checkbox] Improved TsDoc type annotations |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@twilio-paste/code-block': patch | ||
'@twilio-paste/core': patch | ||
--- | ||
|
||
[Combobox] Improved TsDoc type annotations |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@twilio-paste/chat-log': patch | ||
'@twilio-paste/core': patch | ||
--- | ||
|
||
[Chat Log] Improved TsDoc type annotations |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@twilio-paste/callout': patch | ||
'@twilio-paste/core': patch | ||
--- | ||
|
||
[Callout] Improved TsDoc type annotations |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
"@twilio-paste/menu": minor | ||
"@twilio-paste/core": minor | ||
--- | ||
|
||
[Menu] Add all inherited props from "div" element to MenuGroupProps, add new exports: MenuInitialState and MenuStateReturn |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@twilio-paste/avatar': patch | ||
'@twilio-paste/core': patch | ||
--- | ||
|
||
[Avatar] Improved TsDoc annotations |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@twilio-paste/button-group': patch | ||
'@twilio-paste/core': patch | ||
--- | ||
|
||
[Button Group] Improved TsDoc type annotations |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@twilio-paste/account-switcher': patch | ||
'@twilio-paste/core': patch | ||
--- | ||
|
||
[Account Switcher] Improved TsDoc annotations |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@twilio-paste/badge': patch | ||
'@twilio-paste/core': patch | ||
--- | ||
|
||
[Badge] Improved TsDoc type annotations |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
packages/paste-core/components/account-switcher/src/AccountSwitcher.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
packages/paste-core/components/account-switcher/src/AccountSwitcherBadge.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 11 additions & 1 deletion
12
packages/paste-core/components/account-switcher/src/AccountSwitcherGroup.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
packages/paste-core/components/account-switcher/src/AccountSwitcherItem.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
packages/paste-core/components/account-switcher/src/AccountSwitcherItemRadio.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 11 additions & 1 deletion
12
packages/paste-core/components/account-switcher/src/AccountSwitcherSeparator.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 20 additions & 7 deletions
27
packages/paste-core/components/account-switcher/src/index.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,20 @@ | ||
export * from "./AccountSwitcher"; | ||
export * from "./AccountSwitcherGroup"; | ||
export * from "./AccountSwitcherSeparator"; | ||
export * from "./AccountSwitcherItem"; | ||
export * from "./AccountSwitcherItemRadio"; | ||
export * from "./AccountSwitcherBadge"; | ||
export * from "./useAccountSwitcher"; | ||
import type { AccountSwitcherInitialState, AccountSwitcherStateReturn } from "./useAccountSwitcher"; | ||
|
||
// for the sake of documenting the types we rename the state hook types to append Props to the name, so we can docuemnt them and not cause a breaking change. | ||
type AccountSwitcherStateReturnProps = AccountSwitcherStateReturn; | ||
type AccountSwitcherInitialStateProps = AccountSwitcherInitialState; | ||
|
||
export type { AccountSwitcherStateReturnProps, AccountSwitcherInitialStateProps }; | ||
export { AccountSwitcherBadge } from "./AccountSwitcherBadge"; | ||
export type { AccountSwitcherBadgeProps } from "./AccountSwitcherBadge"; | ||
export { AccountSwitcher } from "./AccountSwitcher"; | ||
export type { AccountSwitcherProps } from "./AccountSwitcher"; | ||
export { AccountSwitcherItem } from "./AccountSwitcherItem"; | ||
export type { AccountSwitcherItemProps } from "./AccountSwitcherItem"; | ||
export { AccountSwitcherItemRadio } from "./AccountSwitcherItemRadio"; | ||
export type { AccountSwitcherItemRadioProps } from "./AccountSwitcherItemRadio"; | ||
export { AccountSwitcherGroup } from "./AccountSwitcherGroup"; | ||
export type { AccountSwitcherGroupProps } from "./AccountSwitcherGroup"; | ||
export { AccountSwitcherSeparator } from "./AccountSwitcherSeparator"; | ||
export type { AccountSwitcherSeparatorProps } from "./AccountSwitcherSeparator"; | ||
export { useAccountSwitcherState } from "./useAccountSwitcher"; |
5 changes: 5 additions & 0 deletions
5
packages/paste-core/components/account-switcher/src/useAccountSwitcher.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,6 @@ | ||
export { useMenuState as useAccountSwitcherState } from "@twilio-paste/menu"; | ||
|
||
export type { | ||
MenuInitialState as AccountSwitcherInitialState, | ||
MenuStateReturn as AccountSwitcherStateReturn, | ||
} from "@twilio-paste/menu"; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can merge a lot of these changesets into a single one, with the same message:
ie:
The benefit is, I suspect, it wont bump core 10+ times
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'll only bump it once, it rolls core up into a single minor or patch. The advantage here is that you get a package level dedicated changelog entry. So you're not sharing a single changelog entry for multiple packages, making the package changelog much more isolated and specific to that package only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know