removed preg_replace with /e modifier #123

Merged
merged 2 commits into from Jun 13, 2013

Projects

None yet

2 participants

@caseysoftware

switched from using preg_replace with /e as it's deprecated in 5.5 and not supported in some environments;
while an anonymous function would work, by using create_function we can stay 5.2 compatible;
necessary for Google App Engine compatibility;

@caseysoftware caseysoftware removed preg_replace with /e modifier
switched from using preg_replace with /e as it's deprecated in 5.5 and
not supported in some environments;
while an anonymous function would work, by using create_function we can
stay 5.2 compatible
e975ffa
@kevinburke

It looks like the tests are failing with this message:

preg_replace_callback(): Modifier /e cannot be used with replacement callback

https://travis-ci.org/twilio/twilio-php/jobs/7790027

@kevinburke

If you turn it into a named function, you can use these tests:

ff981aa

@caseysoftware caseysoftware merged commit f1e4ff8 into twilio:master Jun 13, 2013

1 check passed

Details default The Travis CI build passed
@caseysoftware caseysoftware deleted the unknown repository branch Jun 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment