Add a HTTP stream based HTTP client for environments that lack cURL. #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sometimes I want to override __call method for some reason. For example I always want to call say method with language option "'language' => 'ja-jp');".
Conflicts: Services/Twilio.php
| @@ -87,7 +87,10 @@ public static function decamelize($word) | |||
| * @return string | |||
| */ | |||
| public static function camelize($word) { | |||
| return preg_replace('/(^|_)([a-z])/e', 'strtoupper("\\2")', $word); | |||
There was a problem hiding this comment.
As written here, using the anonymous function breaks PHP 5.2 compatibility.
By using create_function - as in my pull request: #123 - we fix the /e issue and keep 5.2 compatibility.
There was a problem hiding this comment.
I can revert this then you can merge the other pull request - let me know what's best.
|
Testing complete, this is good. |
| "header" => "Accept-Charset: utf-8\r\n", | ||
| ), | ||
| "ssl" => array( | ||
| 'veryify_peer' => true, |
There was a problem hiding this comment.
Looks like there's a typo here.
There was a problem hiding this comment.
As noted above. @sjlangley will fix.
- Fix debug flag and print debug output if the flag is on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As cURL is an optional extension not all host have it enabled.
This falls back to a http streams based approach to making HTTP requests is cURL is not detected.