Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some CSL packages throw warning #41

Closed
TwinFan opened this issue Dec 2, 2018 · 2 comments
Closed

Some CSL packages throw warning #41

TwinFan opened this issue Dec 2, 2018 · 2 comments
Labels
enhancement New feature or request XPMP2 Affects XPMP2 lib

Comments

@TwinFan
Copy link
Owner

TwinFan commented Dec 2, 2018

Describe the bug
LiveTraffic apparently can't handle some CSL packages, which X-IvAp is said to handle without warnings.
These warnings don't render LiveTraffic unusable, so issue has lower prio.

To Reproduce
One package now available to me is "B732_OBJ8_CSL". Starting with this package installed should produce warnings.

Expected behavior
No warnings. Package should be recognized.

Complication
X-IvAp is no longer public code. xplanemp is and reads those files, but there are many forks, I'm not on the latest one as I don't understand their changes any longer.

Screenshots
If applicable, add screenshots to help explain your problem.

Technical Info:

  • OS: [Mac/Win/Linux]
  • X-Plane version:
  • LiveTraffic version:

Log.txt
Extract showing some successful and then some unsuccesful loads.

XSB: Loading package: G:\X-Plane 11 (1)\Resources\plugins\LiveTraffic\Resources\CSL/SF260/xsb_aircraft.txt
XSB: Loading package: G:\X-Plane 11 (1)\Resources\plugins\LiveTraffic\Resources\CSL/Sherpa_ver8_CSL/xsb_aircraft.txt
XSB: Loading package: G:\X-Plane 11 (1)\Resources\plugins\LiveTraffic\Resources\CSL/StinsonAT19_V8_CSL/xsb_aircraft.txt
XSB WARNING: Parse Error in file G:\X-Plane 11 (1)\Resources\plugins\LiveTraffic\Resources\CSL/AT-11_OBJ8_CSL/xsb_aircraft.txt line 10.
              OBJ8 SOLID YES __AT11/MAIN.obj 87M_TEX.png.
XSB WARNING: OBJ8_AIRCARFT command takes 1 argument.
XSB WARNING: Parse Error in file G:\X-Plane 11 (1)\Resources\plugins\LiveTraffic\Resources\CSL/AT-11_OBJ8_CSL/xsb_aircraft.txt line 16.
              OBJ8 SOLID YES __AT11/MAIN.obj MSJ_TEX.png.
XSB WARNING: OBJ8_AIRCARFT command takes 1 argument.
XSB WARNING: Parse Error in file G:\X-Plane 11 (1)\Resources\plugins\LiveTraffic\Resources\CSL/AT-11_OBJ8_CSL/xsb_aircraft.txt line 22.
              OBJ8 SOLID YES __AT11/MAIN.obj NAV_TEX.png.
@TwinFan TwinFan added the bug Something isn't working label Dec 2, 2018
@TwinFan
Copy link
Owner Author

TwinFan commented Dec 13, 2018

Some packages provide additional PNG files, likely texture files, have also seen lins with 2 png files with different lights. Maybe someday I find the implementation using that somewhere and can merge it here, this is why the issue stays open as an enhancement.

For the moment I just ingore the remainder of the line (which happened so far as well, but error handling in this command was buggy...would like crash with too few arguments...and the message was simply wrong: OBJ8_AIRCRAFT instead of OBJ8 and 1 argument instead of 3 arguments).

Changed the message to "INFO" in case of too many arguments:

LT WARNING: Parse Error in file /Users/birger/Applications/X-Plane 10/Resources/plugins/LiveTraffic/Resources/CSL/CARS/xsb_aircraft.txt line 4.
              OBJ8 SOLID YES CARS:ZZZC2.obj ZZZC2.png ZZZC2_LIT.png.
LT INFO: OBJ8 command takes only 3 arguments, rest ignored.

@TwinFan TwinFan added enhancement New feature or request and removed bug Something isn't working labels Dec 13, 2018
@TwinFan TwinFan added the XPMP2 Affects XPMP2 lib label Mar 4, 2019
@TwinFan
Copy link
Owner Author

TwinFan commented Apr 28, 2019

For the remaining warnings there is now a counter in place so that only a count of warnings is written into the log per directory. That's should be it. Closed.

@TwinFan TwinFan closed this as completed Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request XPMP2 Affects XPMP2 lib
Projects
None yet
Development

No branches or pull requests

1 participant