Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync known behaviour with .NET #37

Merged
merged 11 commits into from
Sep 9, 2015
Merged

Sync known behaviour with .NET #37

merged 11 commits into from
Sep 9, 2015

Conversation

roback
Copy link
Member

@roback roback commented Sep 8, 2015

Closes #12, #17, #18, #28.

@roback roback changed the title [WIP] Sync with .NET Sync known issues with .NET Sep 9, 2015
@roback roback changed the title Sync known issues with .NET Sync known behaviour with .NET Sep 9, 2015
dentarg
dentarg reviewed Sep 9, 2015
View reviewed changes
spec/lib/twingly/url/normalization_spec.rb
url = "http://www.example.xn--p1ai/"

expect(normalizer.normalize(url)).to eq([url])
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add test without subdomain here, I suspect it will fail... because of sporkmonger/addressable#199

@roback roback mentioned this pull request Sep 9, 2015
Closed
roback added a commit that referenced this pull request Sep 9, 2015
@roback
Merge pull request #37 from twingly/sync-with-dotnet
18876d2 
Sync known behaviour with .NET
@roback roback merged commit 18876d2 into master Sep 9, 2015
@roback roback deleted the sync-with-dotnet branch September 9, 2015 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roback @dentarg @twingly-mob @walro